Don't log error from metricsPrivate API when GetVariationParams fails to find a

Don't log error from metricsPrivate API when GetVariationParams fails to find a
param, just don't set a value.

BUG=368129
R=rdevlin.cronin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272194

[Devlin, 2014-05-06 18:54:10]

LGTM.

[not at google - send to devlin, 2014-05-06 18:55:13]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-05-06 18:56:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/266353009/1

[Ilya Sherman, 2014-05-06 19:02:21]

/cc Alexei -- do you know whether this error message was important (at least on
official builds)?

[Alexei Svitkine (slow), 2014-05-06 19:08:42]

Not sure. I would check with whoever added this originally.

Otherwise, LGTM.

[not at google - send to devlin, 2014-05-06 20:03:18]

The error is only logged if it's unchecked, so whoever is using the function
isn't checking for the error.

[commit-bot: I haz the power, 2014-05-07 05:46:36]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
  linux_chromium_rel on tryserver.chromium
  mac_chromium_rel on tryserver.chromium
  win_chromium_compile_dbg on tryserver.chromium
  win_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-07 11:48:48]

FYI, CQ is re-trying this CL (attempt #2).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
  linux_chromium_rel on tryserver.chromium
  mac_chromium_rel on tryserver.chromium
  win_chromium_compile_dbg on tryserver.chromium
  win_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-07 12:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-07 12:41:47]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
  linux_chromium_rel on tryserver.chromium

[not at google - send to devlin, 2014-05-07 15:04:04]

Fixed test failure. This API has a pretty impressive whitelist:

      "A948368FC53BE437A55FEB414106E207925482F5",  // File manager
      "2FC374607C2DF285634B67C64A2E356C607091C3",  // Quickoffice
      "3727DD3E564B6055387425027AD74C58784ACC15",  // Quickoffice internal
      "12E618C3C6E97495AAECF2AC12DEB082353241C6",  // QO component extension
      "3727DD3E564B6055387425027AD74C58784ACC15",  // Editor
      "C41AD9DCD670210295614257EF8C9945AD68D86E",  // Google Now
      "6EEEA7775E79C735E4BA1F24DBB191BDACB1262C",  // RU-NTP
      "7AE714FFD394E073F0294CFA134C9F91DB5FBAA4",  // CCD Development
      "C7DA3A55C2355F994D3FDDAD120B426A0DF63843",  // CCD Testing
      "75E3CFFFC530582C583E4690EF97C70B9C8423B7",  // CCD Release
      "D5736E4B5CF695CB93A2FB57E4FDC6E5AFAB6FE2",  // http://crbug.com/312900.
      "D57DE394F36DC1C3220E7604C575D29C51A6C495"   // http://crbug.com/319444.

however there is only 1 non-test use of getVariationParams in chromium (Now) and
there are no instances of it on the webstore. so should be safe.

https://codereview.chromium.org/266353009/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/metrics_private.json (right):

https://codereview.chromium.org/266353009/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/metrics_private.json:72: "optional": true,
this now just matches the comment

https://codereview.chromium.org/266353009/diff/20001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/metrics/test.js (right):

https://codereview.chromium.org/266353009/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/metrics/test.js:93:
chrome.test.assertEq(undefined, chrome.runtime.lastError);
Now's use of this function and the test disagree.

[not at google - send to devlin, 2014-05-07 15:04:09]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-05-07 15:10:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/266353009/20001

[commit-bot: I haz the power, 2014-05-07 19:52:08]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium

[commit-bot: I haz the power, 2014-05-07 22:18:02]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium

[commit-bot: I haz the power, 2014-05-07 22:52:17]

FYI, CQ is re-trying this CL (attempt #2).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium

[commit-bot: I haz the power, 2014-05-08 00:11:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 00:11:02]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium

[not at google - send to devlin, 2014-05-22 14:37:33]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-05-22 14:38:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/266353009/20001

[commit-bot: I haz the power, 2014-05-22 15:45:38]

Change committed as 272194