Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1819)

Unified Diff: chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

Issue 266353009: Don't log error from metricsPrivate API when GetVariationParams fails to find a (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make test pass Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
diff --git a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
index 0b344442580e4bc321f4dc996a41131c8b9a4a20..66d4ee98cfbe235e0eb7134820cc4a476c3c5d05 100644
--- a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
+++ b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
@@ -59,13 +59,10 @@ bool MetricsPrivateGetVariationParamsFunction::RunSync() {
EXTENSION_FUNCTION_VALIDATE(params.get());
GetVariationParams::Results::Params result;
- if (!chrome_variations::GetVariationParams(
+ if (chrome_variations::GetVariationParams(
params->name, &result.additional_properties)) {
- SetError("Variation parameters are unavailable.");
- return false;
+ SetResult(result.ToValue().release());
}
-
- SetResult(result.ToValue().release());
return true;
}
« no previous file with comments | « no previous file | chrome/common/extensions/api/metrics_private.json » ('j') | chrome/common/extensions/api/metrics_private.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698