chrome/common/extensions/api/metrics_private.json - Issue 266353009: Don't log error from metricsPrivate API when GetVariationParams fails to find a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/metrics_private.json

Issue 266353009: Don't log error from metricsPrivate API when GetVariationParams fails to find a (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: make test pass Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/metrics_private/metrics_private_api.cc ('k') | chrome/test/data/extensions/api_test/metrics/test.js » ('j') | chrome/test/data/extensions/api_test/metrics/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/metrics_private.json

diff --git a/chrome/common/extensions/api/metrics_private.json b/chrome/common/extensions/api/metrics_private.json

index 28edefe156078ea8fd1a71400c9fef3a08b004b0..0778440b325db5d3db0fe4f05d3e38bd98c278f1 100644

--- a/chrome/common/extensions/api/metrics_private.json

+++ b/chrome/common/extensions/api/metrics_private.json

@@ -69,6 +69,7 @@

"parameters": [

{

"name": "params",

+ "optional": true,

not at google - send to devlin 2014/05/07 15:04:04 this now just matches the comment

"type": "object",

"additionalProperties": { "type": "string" }

}