Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2663333004: Convert dom_distiller::WebContentsMainFrameObserver to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
nyquist
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert dom_distiller::WebContentsMainFrameObserver to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2663333004 Cr-Commit-Position: refs/heads/master@{#447579} Committed: https://chromium.googlesource.com/chromium/src/+/5a063aecb2a8724e483a3ff1c682622e97e0426e

Patch Set 1 #

Total comments: 2

Patch Set 2 : undo testing change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -47 lines) Patch
M components/dom_distiller/content/browser/web_contents_main_frame_observer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/dom_distiller/content/browser/web_contents_main_frame_observer.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M components/dom_distiller/content/browser/web_contents_main_frame_observer_unittest.cc View 5 chunks +25 lines, -34 lines 0 comments Download
M content/public/browser/navigation_handle.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/navigation_handle.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
jam
3 years, 10 months ago (2017-02-01 01:10:37 UTC) #7
nyquist
https://codereview.chromium.org/2663333004/diff/20001/content/test/web_contents_observer_sanity_checker.cc File content/test/web_contents_observer_sanity_checker.cc (right): https://codereview.chromium.org/2663333004/diff/20001/content/test/web_contents_observer_sanity_checker.cc#newcode131 content/test/web_contents_observer_sanity_checker.cc:131: //AssertRenderFrameExists(new_host->GetParent()); It looks from the comments in the test ...
3 years, 10 months ago (2017-02-01 07:10:04 UTC) #10
jam
https://codereview.chromium.org/2663333004/diff/20001/content/test/web_contents_observer_sanity_checker.cc File content/test/web_contents_observer_sanity_checker.cc (right): https://codereview.chromium.org/2663333004/diff/20001/content/test/web_contents_observer_sanity_checker.cc#newcode131 content/test/web_contents_observer_sanity_checker.cc:131: //AssertRenderFrameExists(new_host->GetParent()); On 2017/02/01 07:10:04, nyquist wrote: > It looks ...
3 years, 10 months ago (2017-02-01 15:31:04 UTC) #13
nyquist
lgtm
3 years, 10 months ago (2017-02-01 17:45:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663333004/40001
3 years, 10 months ago (2017-02-01 19:30:26 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 19:36:04 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5a063aecb2a8724e483a3ff1c682...

Powered by Google App Engine
This is Rietveld 408576698