components/dom_distiller/content/browser/web_contents_main_frame_observer.h - Issue 2663333004: Convert dom_distiller::WebContentsMainFrameObserver to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/browser/web_contents_main_frame_observer.h

Issue 2663333004: Convert dom_distiller::WebContentsMainFrameObserver to use the new navigation callbacks. (Closed)

Patch Set: undo testing change Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/dom_distiller/content/browser/web_contents_main_frame_observer.h

diff --git a/components/dom_distiller/content/browser/web_contents_main_frame_observer.h b/components/dom_distiller/content/browser/web_contents_main_frame_observer.h

index 231a30476e6a962da22cbc1397b52e4a94d95fae..9babbedccf27e5a82220c6c8433e5ffa827474aa 100644

--- a/components/dom_distiller/content/browser/web_contents_main_frame_observer.h

+++ b/components/dom_distiller/content/browser/web_contents_main_frame_observer.h

@@ -30,9 +30,8 @@ class WebContentsMainFrameObserver

// content::WebContentsObserver implementation.

void DocumentLoadedInFrame(

content::RenderFrameHost* render_frame_host) override;

- void DidNavigateMainFrame(

- const content::LoadCommittedDetails& details,

- const content::FrameNavigateParams& params) override;

+ void DidFinishNavigation(

+ content::NavigationHandle* navigation_handle) override;

void RenderProcessGone(base::TerminationStatus status) override;

private:

« no previous file with comments | « no previous file | components/dom_distiller/content/browser/web_contents_main_frame_observer.cc » ('j') | no next file with comments »