[NTP::Cleanup] Store tab id as int in SnippetArticle.

components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

Index: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
diff --git a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
index 760785e756839aa0aa2bb715814d5d3aa2bdb0c7..f8056d0f64215d24b6dbce9cb893877aac661673 100644
--- a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
+++ b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
@@ -291,7 +291,10 @@ ContentSuggestion RecentTabSuggestionsProvider::ConvertOfflinePage(
   suggestion.set_publish_date(offline_page.creation_time);
   suggestion.set_publisher_name(base::UTF8ToUTF16(offline_page.url.host()));
   auto extra = base::MakeUnique<RecentTabSuggestionExtra>();
-  extra->tab_id = offline_page.client_id.id;
+  int tab_id;
+  bool success = base::StringToInt(offline_page.client_id.id, &tab_id);
+  DCHECK(success);
+  extra->tab_id = tab_id;

[jkrcal, 2017/02/01 09:27:13]

Wouldn't it make sense to filter out the suggestion if !success?

It seems like this would generate a suggestion that does not react to clicks.

[vitaliii, 2017/02/01 09:34:29]

There is a DCHECK for this.
The assumption is that |offline_page.client_id.id| is a tab_id.

As for suggestions that do not react to clicks, this is just a workaround before
we start removing them when their tab is closed. Having bad tab_id is
technically a reason why we are having them, but the tab_id is bad not because
we couldn't parse it, but because the tab has been closed.

   extra->offline_page_id = offline_page.offline_id;
   suggestion.set_recent_tab_suggestion_extra(std::move(extra));
   return suggestion;