components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc - Issue 2663183002: [NTP::Cleanup] Store tab id as int in SnippetArticle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

Issue 2663183002: [NTP::Cleanup] Store tab id as int in SnippetArticle. (Closed)

Patch Set: clean rebase. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc ('K') | « components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

diff --git a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

index 862b24bfecf5fd67e07deb09064f51cf56df2c18..64acc9347602c279b8b6eedf9c99507aa752edd2 100644

--- a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

+++ b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

@@ -39,7 +39,10 @@ namespace ntp_snippets {

namespace {

OfflinePageItem CreateDummyRecentTab(int id) {

- return test::CreateDummyOfflinePageItem(id, offline_pages::kLastNNamespace);

+ OfflinePageItem item =

+ test::CreateDummyOfflinePageItem(id, offline_pages::kLastNNamespace);

+ item.client_id.id = base::IntToString(id);

+ return item;

}

std::vector<OfflinePageItem> CreateDummyRecentTabs(