[NTP::Cleanup] Store tab id as int in SnippetArticle.

components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 273 matching lines @@
   if (offline_page.title.empty()) {
     // TODO(vitaliii): Remove this fallback once the OfflinePageModel provides
     // titles for all (relevant) OfflinePageItems.
     suggestion.set_title(base::UTF8ToUTF16(offline_page.url.spec()));
   } else {
     suggestion.set_title(offline_page.title);
   }
   suggestion.set_publish_date(offline_page.creation_time);
   suggestion.set_publisher_name(base::UTF8ToUTF16(offline_page.url.host()));
   auto extra = base::MakeUnique<RecentTabSuggestionExtra>();
-  extra->tab_id = offline_page.client_id.id;
+  int tab_id;
+  bool success = base::StringToInt(offline_page.client_id.id, &tab_id);
+  DCHECK(success);
+  extra->tab_id = tab_id;

[jkrcal, 2017/02/01 09:27:13]

Wouldn't it make sense to filter out the suggestion if !success?

It seems like this would generate a suggestion that does not react to clicks.

[vitaliii, 2017/02/01 09:34:29]

There is a DCHECK for this.
The assumption is that |offline_page.client_id.id| is a tab_id.

As for suggestions that do not react to clicks, this is just a workaround before
we start removing them when their tab is closed. Having bad tab_id is
technically a reason why we are having them, but the tab_id is bad not because
we couldn't parse it, but because the tab has been closed.

   extra->offline_page_id = offline_page.offline_id;
   suggestion.set_recent_tab_suggestion_extra(std::move(extra));
   return suggestion;
 }
 
 std::vector<ContentSuggestion>
 RecentTabSuggestionsProvider::GetMostRecentlyCreatedWithoutDuplicates(
     std::vector<const OfflinePageItem*> offline_page_items) const {
   // |std::unique| only removes duplicates that immediately follow each other.
   // Thus, first, we have to sort by URL and creation time and only then remove
@@ skipping 38 matching lines @@
 }
 
 void RecentTabSuggestionsProvider::StoreDismissedIDsToPrefs(
     const std::set<std::string>& dismissed_ids) {
   prefs::StoreDismissedIDsToPrefs(pref_service_,
                                   prefs::kDismissedRecentOfflineTabSuggestions,
                                   dismissed_ids);
 }
 
 }  // namespace ntp_snippets