chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java - Issue 2663183002: [NTP::Cleanup] Store tab id as int in SnippetArticle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2663183002: [NTP::Cleanup] Store tab id as int in SnippetArticle. (Closed)

Patch Set: clean rebase. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java » ('j') | components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

index 87e5e0039afed783181ff92eb48ffec379023e5a..8f99716dec7260bb4a3de946f50d62d24e2fca81 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

@@ -280,7 +280,7 @@ public class SnippetsBridge implements SuggestionsSource, SuggestionsMetricsRepo

@CalledByNative

private static void setRecentTabDataForSuggestion(

- SnippetArticle suggestion, String tabId, long offlinePageId) {

+ SnippetArticle suggestion, int tabId, long offlinePageId) {

suggestion.setRecentTabData(tabId, offlinePageId);

}