Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3498)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

Issue 2663183002: [NTP::Cleanup] Store tab id as int in SnippetArticle. (Closed)
Patch Set: clean rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
index 95f20e506c45ccf4ba098e1ba6c5db12385446d8..f3d6805d2e2b7a95a605994ff8beac62b750b2fb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
@@ -58,7 +58,7 @@ public class SnippetArticle {
private String mAssetDownloadMimeType;
/** The tab id of the corresponding tab (only for recent tab articles). */
- private String mRecentTabId;
+ private int mRecentTabId;
/** The offline id of the corresponding offline page, if any. */
private Long mOfflinePageOfflineId;
@@ -173,7 +173,7 @@ public class SnippetArticle {
* @return the corresponding recent tab id. May only be called if this snippet is a recent tab
* article.
*/
- public String getRecentTabId() {
+ public int getRecentTabId() {
assert isRecentTab();
return mRecentTabId;
}
@@ -182,7 +182,7 @@ public class SnippetArticle {
* Sets tab id and offline page id for recent tab articles. May only be called if this snippet
* is a recent tab article.
*/
- public void setRecentTabData(String tabId, long offlinePageId) {
+ public void setRecentTabData(int tabId, long offlinePageId) {
assert isRecentTab();
mRecentTabId = tabId;
setOfflinePageOfflineId(offlinePageId);

Powered by Google App Engine
This is Rietveld 408576698