Fix id tracking bug in ICCProfile

Fix id tracking bug in ICCProfile

ICCProfiles are given an id when they are created, and are assumed to
be unique.

This breaks down in some tests, where we create ICCProfiles in the
browser and send them to the renderer (as usual), but then also create
test ICCProfiles in the in the renderer, that can conflict with the
ids provided by the browser.

Fix this by using hard-coded ids for the test ICCProfiles that are
created by the renderer.

BUG=634102
Review-Url: https://codereview.chromium.org/2663153002
Cr-Commit-Position: refs/heads/master@{#447874}
Committed: https://chromium.googlesource.com/chromium/src/+/9b2a0b1bc7034aa17ede1914e0620d3f71fe8dec

[ccameron, 2017-01-31 04:26:49]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 04:27:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-01-31 05:35:55]

ccameron@chromium.org changed reviewers:
+ junov@chromium.org

[ccameron, 2017-01-31 05:35:56]

ptal -- I wanted to chop this part off from the larger patch

[commit-bot: I haz the power, 2017-01-31 06:44:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 06:44:33]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-02-01 19:41:20]

ping

[ccameron, 2017-02-02 17:21:56]

ping again

[Justin Novosad, 2017-02-02 19:13:19]

lgtm

[Justin Novosad, 2017-02-02 19:22:06]

https://codereview.chromium.org/2663153002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp (right):

https://codereview.chromium.org/2663153002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp:37:
gTargetColorSpace = space.release();
Drive by meta comment: Just checking... There is a plan to eventually get rid of
this global, right?  Because you could have windows on different displays that
belong to the same render process.  The target color space should really hand
off of Frame IMHO.

[Justin Novosad, 2017-02-02 19:23:20]

On 2017/02/02 19:22:06, Justin Novosad wrote:

> The target color space should really hand
> off of Frame IMHO.

I meant "hang off of"

[ccameron, 2017-02-02 20:38:44]

On 2017/02/02 19:22:06, Justin Novosad wrote:
>
https://codereview.chromium.org/2663153002/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp (right):
> 
>
https://codereview.chromium.org/2663153002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp:37:
> gTargetColorSpace = space.release();
> Drive by meta comment: Just checking... There is a plan to eventually get rid
of
> this global, right?  Because you could have windows on different displays that
> belong to the same render process.  The target color space should really hand
> off of Frame IMHO.

Yes, the plan is for this to be obliterated.

[ccameron, 2017-02-02 20:39:38]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-02-02 20:40:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 23:29:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486067978088870, "parent_rev":
"db439658632e1ddae019b79e2fd2013c8b4f567f", "commit_rev":
"9b2a0b1bc7034aa17ede1914e0620d3f71fe8dec"}

[commit-bot: I haz the power, 2017-02-02 23:29:52]

Description was changed from

==========
Fix id tracking bug in ICCProfile

ICCProfiles are given an id when they are created, and are assumed to
be unique.

This breaks down in some tests, where we create ICCProfiles in the
browser and send them to the renderer (as usual), but then also create
test ICCProfiles in the in the renderer, that can conflict with the
ids provided by the browser.

Fix this by using hard-coded ids for the test ICCProfiles that are
created by the renderer.

BUG=634102
==========

to

==========
Fix id tracking bug in ICCProfile

ICCProfiles are given an id when they are created, and are assumed to
be unique.

This breaks down in some tests, where we create ICCProfiles in the
browser and send them to the renderer (as usual), but then also create
test ICCProfiles in the in the renderer, that can conflict with the
ids provided by the browser.

Fix this by using hard-coded ids for the test ICCProfiles that are
created by the renderer.

BUG=634102

Review-Url: https://codereview.chromium.org/2663153002
Cr-Commit-Position: refs/heads/master@{#447874}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b2a0b1bc7034aa17ede1914e062...
==========

[commit-bot: I haz the power, 2017-02-02 23:29:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b2a0b1bc7034aa17ede1914e062...