Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp

Issue 2663153002: Fix id tracking bug in ICCProfile (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/icc_profile.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp b/third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp
index 65a560a1b30309197b0221919b7667ed94038463..755e9a66f43e5dc6d9d07cbf390d17b71e2d010b 100644
--- a/third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp
+++ b/third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp
@@ -33,9 +33,10 @@ void ColorBehavior::setGlobalTargetColorProfile(
// Attempt to convert the ICC profile to an SkColorSpace.
if (!(profile == gfx::ICCProfile())) {
+ sk_sp<SkColorSpace> space = profile.GetColorSpace().ToSkColorSpace();
+ gTargetColorSpace = space.release();
Justin Novosad 2017/02/02 19:22:06 Drive by meta comment: Just checking... There is a
+
const std::vector<char>& data = profile.GetData();
- gTargetColorSpace =
- SkColorSpace::MakeICC(data.data(), data.size()).release();
sk_sp<SkICC> skICC = SkICC::Make(data.data(), data.size());
if (skICC) {
SkMatrix44 toXYZD50;
« no previous file with comments | « no previous file | ui/gfx/icc_profile.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698