Chromium Code Reviews
DescriptionRevert of cros: Test for overlapping ContinueSessionRestore calls (patchset #1 id:1 of https://codereview.chromium.org/2658953002/ )
Reason for revert:
This new test fails flakily on the Linux ChromiumOS Tests (dbg)(1) bot.
See example failures:
https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/22001
https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/22005
Original issue's description:
> cros: Test for overlapping ContinueSessionRestore calls
>
> OAuth2LoginManager::ContinueSessionRestore with strategy
> RESTORE_FROM_SAVED_OAUTH2_REFRESH_TOKEN would call
> TokenService::LoadCredentials that does not support
> multiple concurrent calls. Add a test to verify that it
> does not attempt to overlap LoadCredentials calls.
>
> BUG=682695
> TEST=OAuth2Test.OverlappingContinueSessionRestore
>
> Review-Url: https://codereview.chromium.org/2658953002
> Cr-Commit-Position: refs/heads/master@{#447020}
> Committed: https://chromium.googlesource.com/chromium/src/+/5555191b32d4d5e6b8b956e310e1eb64aa7bc188
TBR=jdufault@chromium.org,derat@chromium.org,xiyuan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=682695
Review-Url: https://codereview.chromium.org/2663063002
Cr-Commit-Position: refs/heads/master@{#447115}
Committed: https://chromium.googlesource.com/chromium/src/+/dfecbb4466fbfa9ab590b5a9917d9515ab4630c2
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||