cros: Test for overlapping ContinueSessionRestore calls

cros: Test for overlapping ContinueSessionRestore calls

OAuth2LoginManager::ContinueSessionRestore with strategy
RESTORE_FROM_SAVED_OAUTH2_REFRESH_TOKEN would call
TokenService::LoadCredentials that does not support
multiple concurrent calls. Add a test to verify that it
does not attempt to overlap LoadCredentials calls.

BUG=682695
TEST=OAuth2Test.OverlappingContinueSessionRestore

Review-Url: https://codereview.chromium.org/2658953002
Cr-Commit-Position: refs/heads/master@{#447020}
Committed: https://chromium.googlesource.com/chromium/src/+/5555191b32d4d5e6b8b956e310e1eb64aa7bc188

[xiyuan, 2017-01-26 21:48:46]

xiyuan@chromium.org changed reviewers:
+ derat@chromium.org, jdufault@chromium.org

[xiyuan, 2017-01-26 21:48:51]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 21:49:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 22:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 22:39:08]

Dry run: This issue passed the CQ dry run.

[Daniel Erat, 2017-01-27 01:07:42]

lgtm

thanks for adding this!

[xiyuan, 2017-01-30 18:09:53]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2017-01-30 18:10:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 18:43:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485799793074360, "parent_rev":
"72a84c1c823e0f4eedb24a21a387f0bd5c2907e5", "commit_rev":
"5555191b32d4d5e6b8b956e310e1eb64aa7bc188"}

[commit-bot: I haz the power, 2017-01-30 18:44:16]

Description was changed from

==========
cros: Test for overlapping ContinueSessionRestore calls

OAuth2LoginManager::ContinueSessionRestore with strategy
RESTORE_FROM_SAVED_OAUTH2_REFRESH_TOKEN would call
TokenService::LoadCredentials that does not support
multiple concurrent calls. Add a test to verify that it
does not attempt to overlap LoadCredentials calls.

BUG=682695
TEST=OAuth2Test.OverlappingContinueSessionRestore
==========

to

==========
cros: Test for overlapping ContinueSessionRestore calls

OAuth2LoginManager::ContinueSessionRestore with strategy
RESTORE_FROM_SAVED_OAUTH2_REFRESH_TOKEN would call
TokenService::LoadCredentials that does not support
multiple concurrent calls. Add a test to verify that it
does not attempt to overlap LoadCredentials calls.

BUG=682695
TEST=OAuth2Test.OverlappingContinueSessionRestore

Review-Url: https://codereview.chromium.org/2658953002
Cr-Commit-Position: refs/heads/master@{#447020}
Committed:
https://chromium.googlesource.com/chromium/src/+/5555191b32d4d5e6b8b956e310e1...
==========

[commit-bot: I haz the power, 2017-01-30 18:44:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5555191b32d4d5e6b8b956e310e1...

[tsergeant, 2017-01-30 23:56:05]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2663063002/ by tsergeant@chromium.org.

The reason for reverting is: This new test fails flakily on the Linux ChromiumOS
Tests (dbg)(1) bot.

See example failures:
https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS...
https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS....