Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2663023002: Mark ECT as ambiguous if there is a change in the connection type. (Closed)

Created:
3 years, 10 months ago by tbansal1
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Mark ECT as ambiguous if there is a change in the connection type. Mark EffectiveConnectionType (ECT) as ambiguous in the system profile proto when there is a change in the connection type. BUG=686157 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2661563004 Cr-Commit-Position: refs/heads/master@{#446938} (cherry picked from commit e931fa7ddaf6e747b369e433aba0bdf791b2d3a3) Review-Url: https://codereview.chromium.org/2663023002 . Cr-Commit-Position: refs/branch-heads/2987@{#195} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/370efa3eede2c0aa3000895523637dea28b9c502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M components/metrics/net/network_metrics_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/metrics/net/network_metrics_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/net/network_metrics_provider_unittest.cc View 2 chunks +36 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbansal1
3 years, 10 months ago (2017-01-30 22:06:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
370efa3eede2c0aa3000895523637dea28b9c502.

Powered by Google App Engine
This is Rietveld 408576698