Mark ECT as ambiguous if there is a change in the connection type.

Mark ECT as ambiguous if there is a change in the connection type.

Mark EffectiveConnectionType (ECT) as ambiguous in the system profile
proto when there is a change in the connection type.

BUG=686157
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2661563004
Cr-Commit-Position: refs/heads/master@{#446938}
Committed: https://chromium.googlesource.com/chromium/src/+/e931fa7ddaf6e747b369e433aba0bdf791b2d3a3

[tbansal1, 2017-01-27 18:27:02]

Description was changed from

==========
Mark ECT as ambiguous if there is a change in the connection type.

BUG=
==========

to

==========
Mark ECT as ambiguous if there is a change in the connection type.

Mark EffectiveConnectionType (ECT) as ambiguous in the system profile
proto when there is a change in the connection type.

BUG=
==========

[tbansal1, 2017-01-27 18:50:13]

Patchset #2 (id:20001) has been deleted

[tbansal1, 2017-01-27 18:50:17]

Patchset #2 (id:40001) has been deleted

[tbansal1, 2017-01-27 18:50:23]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-01-27 18:50:55]

Description was changed from

==========
Mark ECT as ambiguous if there is a change in the connection type.

Mark EffectiveConnectionType (ECT) as ambiguous in the system profile
proto when there is a change in the connection type.

BUG=
==========

to

==========
Mark ECT as ambiguous if there is a change in the connection type.

Mark EffectiveConnectionType (ECT) as ambiguous in the system profile
proto when there is a change in the connection type.

BUG=686157
==========

[tbansal1, 2017-01-27 18:51:08]

tbansal@chromium.org changed reviewers:
+ asvitkine@chromium.org

[tbansal1, 2017-01-27 18:51:08]

asvitkine: ptal. thanks.

[tbansal1, 2017-01-27 18:54:43]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 18:55:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 20:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 20:10:13]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2017-01-27 22:01:41]

lgtm

https://codereview.chromium.org/2661563004/diff/60001/components/metrics/net/...
File components/metrics/net/network_metrics_provider_unittest.cc (right):

https://codereview.chromium.org/2661563004/diff/60001/components/metrics/net/...
components/metrics/net/network_metrics_provider_unittest.cc:122: #endif  //
OS_CHROMEOS
Nit: Can this goop go into the test harness ctor?

[tbansal1, 2017-01-29 05:17:19]

Description was changed from

==========
Mark ECT as ambiguous if there is a change in the connection type.

Mark EffectiveConnectionType (ECT) as ambiguous in the system profile
proto when there is a change in the connection type.

BUG=686157
==========

to

==========
Mark ECT as ambiguous if there is a change in the connection type.

Mark EffectiveConnectionType (ECT) as ambiguous in the system profile
proto when there is a change in the connection type.

BUG=686157
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-01-29 05:19:25]

Patchset #2 (id:80001) has been deleted

[tbansal1, 2017-01-29 05:20:27]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 05:20:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 06:01:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 06:01:58]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-01-29 07:12:27]

https://codereview.chromium.org/2661563004/diff/60001/components/metrics/net/...
File components/metrics/net/network_metrics_provider_unittest.cc (right):

https://codereview.chromium.org/2661563004/diff/60001/components/metrics/net/...
components/metrics/net/network_metrics_provider_unittest.cc:122: #endif  //
OS_CHROMEOS
On 2017/01/27 22:01:40, Alexei Svitkine (very slow) wrote:
> Nit: Can this goop go into the test harness ctor?

Done.

[tbansal1, 2017-01-29 07:12:34]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-01-29 07:12:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2661563004/#ps100001
(title: "asvitkine comments")

[commit-bot: I haz the power, 2017-01-29 07:12:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 07:20:42]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485673954167700,
"parent_rev": "73f8d7ec73f5ff5f7fd7a24862aef82f73f103e7", "commit_rev":
"e931fa7ddaf6e747b369e433aba0bdf791b2d3a3"}

[commit-bot: I haz the power, 2017-01-29 07:21:52]

Description was changed from

==========
Mark ECT as ambiguous if there is a change in the connection type.

Mark EffectiveConnectionType (ECT) as ambiguous in the system profile
proto when there is a change in the connection type.

BUG=686157
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Mark ECT as ambiguous if there is a change in the connection type.

Mark EffectiveConnectionType (ECT) as ambiguous in the system profile
proto when there is a change in the connection type.

BUG=686157
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2661563004
Cr-Commit-Position: refs/heads/master@{#446938}
Committed:
https://chromium.googlesource.com/chromium/src/+/e931fa7ddaf6e747b369e433aba0...
==========

[commit-bot: I haz the power, 2017-01-29 07:21:53]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/e931fa7ddaf6e747b369e433aba0...