Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: chrome/browser/ui/views/cookie_info_view.cc

Issue 2663013003: Rename various LayoutDelegate types/functions for brevity and consistency. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/cookie_info_view.h" 5 #include "chrome/browser/ui/views/cookie_info_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/i18n/time_formatting.h" 9 #include "base/i18n/time_formatting.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_SENDFOR_LABEL)); 140 l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_SENDFOR_LABEL));
141 send_for_value_field_ = new views::Textfield; 141 send_for_value_field_ = new views::Textfield;
142 created_label_ = new views::Label( 142 created_label_ = new views::Label(
143 l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_CREATED_LABEL)); 143 l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_CREATED_LABEL));
144 created_value_field_ = new views::Textfield; 144 created_value_field_ = new views::Textfield;
145 expires_label_ = new views::Label( 145 expires_label_ = new views::Label(
146 l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_EXPIRES_LABEL)); 146 l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_EXPIRES_LABEL));
147 expires_value_field_ = new views::Textfield; 147 expires_value_field_ = new views::Textfield;
148 148
149 views::GridLayout* layout = new views::GridLayout(this); 149 views::GridLayout* layout = new views::GridLayout(this);
150 layout->SetInsets( 150 layout->SetInsets(0,
151 0, LayoutDelegate::Get()->GetLayoutDistance( 151 LayoutDelegate::Get()->GetMetric(
152 LayoutDelegate::LayoutDistanceType::DIALOG_BUTTON_MARGIN), 152 LayoutDelegate::Metric::DIALOG_BUTTON_MARGIN),
153 0, LayoutDelegate::Get()->GetLayoutDistance( 153 0,
154 LayoutDelegate::LayoutDistanceType::DIALOG_BUTTON_MARGIN)); 154 LayoutDelegate::Get()->GetMetric(
155 LayoutDelegate::Metric::DIALOG_BUTTON_MARGIN));
155 SetLayoutManager(layout); 156 SetLayoutManager(layout);
156 157
157 int three_column_layout_id = 0; 158 int three_column_layout_id = 0;
158 views::ColumnSet* column_set = layout->AddColumnSet(three_column_layout_id); 159 views::ColumnSet* column_set = layout->AddColumnSet(three_column_layout_id);
159 column_set->AddColumn(LayoutDelegate::Get()->GetControlLabelGridAlignment(), 160 column_set->AddColumn(LayoutDelegate::Get()->GetControlLabelGridAlignment(),
160 views::GridLayout::CENTER, 0, 161 views::GridLayout::CENTER, 0,
161 views::GridLayout::USE_PREF, 0, 0); 162 views::GridLayout::USE_PREF, 0, 0);
162 column_set->AddPaddingColumn(0, LayoutDelegate::Get()->GetLayoutDistance( 163 column_set->AddPaddingColumn(
163 LayoutDelegate::LayoutDistanceType:: 164 0,
164 RELATED_CONTROL_HORIZONTAL_SPACING)); 165 LayoutDelegate::Get()->GetMetric(
166 LayoutDelegate::Metric::RELATED_CONTROL_HORIZONTAL_SPACING));
165 column_set->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER, 167 column_set->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER,
166 0, views::GridLayout::USE_PREF, 0, 0); 168 0, views::GridLayout::USE_PREF, 0, 0);
167 column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::CENTER, 169 column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::CENTER,
168 1, views::GridLayout::USE_PREF, 0, 0); 170 1, views::GridLayout::USE_PREF, 0, 0);
169 171
170 AddLabelRow(three_column_layout_id, layout, name_label_, name_value_field_); 172 AddLabelRow(three_column_layout_id, layout, name_label_, name_value_field_);
171 AddLabelRow(three_column_layout_id, layout, content_label_, 173 AddLabelRow(three_column_layout_id, layout, content_label_,
172 content_value_field_); 174 content_value_field_);
173 AddLabelRow(three_column_layout_id, layout, domain_label_, 175 AddLabelRow(three_column_layout_id, layout, domain_label_,
174 domain_value_field_); 176 domain_value_field_);
175 AddLabelRow(three_column_layout_id, layout, path_label_, path_value_field_); 177 AddLabelRow(three_column_layout_id, layout, path_label_, path_value_field_);
176 AddLabelRow(three_column_layout_id, layout, send_for_label_, 178 AddLabelRow(three_column_layout_id, layout, send_for_label_,
177 send_for_value_field_); 179 send_for_value_field_);
178 AddLabelRow(three_column_layout_id, layout, created_label_, 180 AddLabelRow(three_column_layout_id, layout, created_label_,
179 created_value_field_); 181 created_value_field_);
180 AddLabelRow(three_column_layout_id, layout, expires_label_, 182 AddLabelRow(three_column_layout_id, layout, expires_label_,
181 expires_value_field_); 183 expires_value_field_);
182 } 184 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698