Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2662953002: Fix two tests in http/tests/serviceworker/ to handle the correct behavior of undefined in arrays, a… (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
Reviewers:
nhiroki
CC:
blink-reviews, chromium-reviews, falken+watch_chromium.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix two tests in http/tests/serviceworker/ to handle the correct behavior of undefined in arrays, and suppress them until the fix relands. These tests currently depend on the incorrect behavior wherein "undefined" elements are sometimes removed from arrays (when they should be present, but have the value undefined). TestExpectations lines will be removed once the V8 change re-rolls. V8 revert was: https://chromium.googlesource.com/v8/v8/+/b861a8400991976e6fd7d7abc9843e4fe7dc576e BUG=chromium:665820 Review-Url: https://codereview.chromium.org/2662953002 Cr-Commit-Position: refs/heads/master@{#447152} Committed: https://chromium.googlesource.com/chromium/src/+/507c8a3ed5bc7686ac0e7d9a6b9db0d0d413a63b

Patch Set 1 #

Patch Set 2 : make clients-matchall-client-types catch the assertion exception correctly, instead of timing out #

Patch Set 3 : whoops, fix TestExpectations file again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-matchall-client-types.html View 1 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (19 generated)
jbroman
At the sending end, these elements are present; this fixes the tests to expect the ...
3 years, 10 months ago (2017-01-30 20:10:27 UTC) #5
nhiroki
LGTM!
3 years, 10 months ago (2017-01-30 21:08:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662953002/40001
3 years, 10 months ago (2017-01-30 23:46:34 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 01:21:07 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/507c8a3ed5bc7686ac0e7d9a6b9d...

Powered by Google App Engine
This is Rietveld 408576698