third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html - Issue 2662953002: Fix two tests in http/tests/serviceworker/ to handle the correct behavior of undefined in arrays, a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html

Issue 2662953002: Fix two tests in http/tests/serviceworker/ to handle the correct behavior of undefined in arrays, a… (Closed)

Patch Set: whoops, fix TestExpectations file again Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-matchall-client-types.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html

index 75f54ebe194f344b5c8d9d396249810e862c0262..c0d0b20b3df455b3f4eb58764a051616a592d5cf 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html

@@ -64,6 +64,6 @@ function wait_for_clientId() {

var expected = [

/* visibilityState, focused, url, frameType */

['visible', true, normalizeURL(scope) + '-frame.html', 'nested'],

- [,,normalizeURL(scope) + '-shared-worker.js', 'none']

+ [undefined, undefined, normalizeURL(scope) + '-shared-worker.js', 'none']

];

</script>