Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2662783003: [LanguageModel] Clear the model when clearing full history (Closed)

Created:
3 years, 10 months ago by jkrcal
Modified:
3 years, 10 months ago
Reviewers:
msramek, groby-ooo-7-16
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[LanguageModel] Clear the model when clearing full history Before this CL, the LanguageModel did not react in any way to user clearing browsing data. This CL adds wiping the model whenever the user clears the complete browsing history. TBR=groby NOTRY=true NOPRESUBMIT=true BUG=683875 Review-Url: https://codereview.chromium.org/2649163003 Cr-Commit-Position: refs/heads/master@{#446350} Committed: https://chromium.googlesource.com/chromium/src/+/afb5fba70d41e1cc8971942d1d78cffa491933a0 (cherry picked from commit afb5fba70d41e1cc8971942d1d78cffa491933a0) Review-Url: https://codereview.chromium.org/2662783003 Cr-Commit-Position: refs/branch-heads/2987@{#189} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/1e297e01a5092bc072d897cba9309af7c35a9910

Patch Set 1 #

Patch Set 2 : One more file exactly as in the original CL #

Patch Set 3 : Manual merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 2 4 chunks +35 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc View 1 3 chunks +8 lines, -0 lines 0 comments Download
M components/translate/core/browser/language_model.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/language_model.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M components/translate/core/browser/language_model_unittest.cc View 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
jkrcal
Merging the CL 2649163003 to M57. No drover, as there are non-trivial changes in chrome_browsing_data_remover_delegate_unittest.cc ...
3 years, 10 months ago (2017-01-30 15:01:18 UTC) #3
msramek
I confirm that browsing_data/ code is equivalent to https://codereview.chromium.org/2649163003/. LGTM, thanks for tackling this!
3 years, 10 months ago (2017-01-30 16:30:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662783003/60001
3 years, 10 months ago (2017-01-30 21:29:00 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-01-30 21:29:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662783003/60001
3 years, 10 months ago (2017-01-30 21:40:21 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/1e297e01a5092bc072d897cba9309af7c35a9910
3 years, 10 months ago (2017-01-30 21:41:44 UTC) #16
groby-ooo-7-16
3 years, 10 months ago (2017-01-30 21:59:52 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698