Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: components/translate/core/browser/language_model_unittest.cc

Issue 2662783003: [LanguageModel] Clear the model when clearing full history (Closed)
Patch Set: Manual merge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/core/browser/language_model.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/browser/language_model_unittest.cc
diff --git a/components/translate/core/browser/language_model_unittest.cc b/components/translate/core/browser/language_model_unittest.cc
index df8b6bad29de2f8b510d0115d36a8e08fec27348..f59a31bd404f1c2a2723e010f5ae1bf468c09149 100644
--- a/components/translate/core/browser/language_model_unittest.cc
+++ b/components/translate/core/browser/language_model_unittest.cc
@@ -11,6 +11,7 @@
using testing::ElementsAre;
using testing::FloatEq;
using testing::Gt;
+using testing::SizeIs;
namespace {
@@ -105,4 +106,42 @@ TEST(LanguageModelTest, RareLanguageDiscarded) {
ElementsAre(LanguageModel::LanguageInfo{kLang1, 1}));
}
+TEST(LanguageModelTest, ShouldClearHistoryIfAllTimes) {
+ TestingPrefServiceSimple prefs;
+ LanguageModel::RegisterProfilePrefs(prefs.registry());
+ LanguageModel model(&prefs);
+
+ for (int i = 0; i < 100; i++) {
+ model.OnPageVisited(kLang1);
+ }
+
+ EXPECT_THAT(model.GetTopLanguages(), SizeIs(1));
+ EXPECT_THAT(model.GetLanguageFrequency(kLang1), FloatEq(1.0));
+
+ model.ClearHistory(base::Time(), base::Time::Max());
+
+ EXPECT_THAT(model.GetTopLanguages(), SizeIs(0));
+ EXPECT_THAT(model.GetLanguageFrequency(kLang1), FloatEq(0.0));
+}
+
+TEST(LanguageModelTest, ShouldNotClearHistoryIfNotAllTimes) {
+ TestingPrefServiceSimple prefs;
+ LanguageModel::RegisterProfilePrefs(prefs.registry());
+ LanguageModel model(&prefs);
+
+ for (int i = 0; i < 100; i++) {
+ model.OnPageVisited(kLang1);
+ }
+
+ EXPECT_THAT(model.GetTopLanguages(), SizeIs(1));
+ EXPECT_THAT(model.GetLanguageFrequency(kLang1), FloatEq(1.0));
+
+ // Clearing only the last hour of the history has no effect.
+ model.ClearHistory(base::Time::Now() - base::TimeDelta::FromHours(2),
+ base::Time::Max());
+
+ EXPECT_THAT(model.GetTopLanguages(), SizeIs(1));
+ EXPECT_THAT(model.GetLanguageFrequency(kLang1), FloatEq(1.0));
+}
+
} // namespace translate
« no previous file with comments | « components/translate/core/browser/language_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698