|
|
Chromium Code Reviews|
Created:
3 years, 10 months ago by renjieliu1 Modified:
3 years, 10 months ago CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange deprecate assert to DCHECK in CSSVariableData
BUG=672647
Review-Url: https://codereview.chromium.org/2662773002
Cr-Commit-Position: refs/heads/master@{#447168}
Committed: https://chromium.googlesource.com/chromium/src/+/3fd4bea578f28ab1fc10e0c3f2f5591e523020db
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Change deprecate assert to DCHECK in CSSVariableData BUG=672647 ========== to ========== Change deprecate assert to DCHECK in CSSVariableData BUG=672647 ==========
renjieliu@chromium.org changed reviewers: + meade@chromium.org
lgtm
The CQ bit was checked by renjieliu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
renjieliu@chromium.org changed reviewers: + skobes@chromium.org
lgtm
On 2017/01/31 01:08:10, skobes wrote: > lgtm thank you!
The CQ bit was checked by renjieliu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485825559812940, "parent_rev":
"9a94f77d2c827b79ba964ae7d5db4526d82b8c77", "commit_rev":
"3fd4bea578f28ab1fc10e0c3f2f5591e523020db"}
Message was sent while issue was closed.
Description was changed from ========== Change deprecate assert to DCHECK in CSSVariableData BUG=672647 ========== to ========== Change deprecate assert to DCHECK in CSSVariableData BUG=672647 Review-Url: https://codereview.chromium.org/2662773002 Cr-Commit-Position: refs/heads/master@{#447168} Committed: https://chromium.googlesource.com/chromium/src/+/3fd4bea578f28ab1fc10e0c3f2f5... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3fd4bea578f28ab1fc10e0c3f2f5... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
