Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2662773002: Change deprecate assert to DCHECK in CSSVariableData (Closed)

Created:
3 years, 10 months ago by renjieliu1
Modified:
3 years, 10 months ago
Reviewers:
meade_UTC10, skobes
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change deprecate assert to DCHECK in CSSVariableData BUG=672647 Review-Url: https://codereview.chromium.org/2662773002 Cr-Commit-Position: refs/heads/master@{#447168} Committed: https://chromium.googlesource.com/chromium/src/+/3fd4bea578f28ab1fc10e0c3f2f5591e523020db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/CSSVariableData.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
renjieliu1
3 years, 10 months ago (2017-01-29 23:32:37 UTC) #7
meade_UTC10
lgtm
3 years, 10 months ago (2017-01-30 00:34:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662773002/1
3 years, 10 months ago (2017-01-31 00:02:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/353541)
3 years, 10 months ago (2017-01-31 00:12:38 UTC) #12
renjieliu1
3 years, 10 months ago (2017-01-31 00:58:37 UTC) #14
skobes
lgtm
3 years, 10 months ago (2017-01-31 01:08:10 UTC) #15
renjieliu1
On 2017/01/31 01:08:10, skobes wrote: > lgtm thank you!
3 years, 10 months ago (2017-01-31 01:18:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662773002/1
3 years, 10 months ago (2017-01-31 01:19:54 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 02:27:18 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3fd4bea578f28ab1fc10e0c3f2f5...

Powered by Google App Engine
This is Rietveld 408576698