Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/css/CSSVariableData.cpp

Issue 2662773002: Change deprecate assert to DCHECK in CSSVariableData (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSVariableData.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSVariableData.cpp b/third_party/WebKit/Source/core/css/CSSVariableData.cpp
index 58f2fa5d56bb6df34dae1b276940e250a9eeacda..7406620830e7247f8666215e52c5ed383829c5a6 100644
--- a/third_party/WebKit/Source/core/css/CSSVariableData.cpp
+++ b/third_party/WebKit/Source/core/css/CSSVariableData.cpp
@@ -13,7 +13,7 @@
namespace blink {
StylePropertySet* CSSVariableData::propertySet() {
- ASSERT(!m_needsVariableResolution);
+ DCHECK(!m_needsVariableResolution);
if (!m_cachedPropertySet) {
m_propertySet = CSSParser::parseCustomPropertySet(m_tokens);
m_cachedPropertySet = true;
@@ -35,7 +35,7 @@ void CSSVariableData::updateTokens(const CSSParserTokenRange& range) {
m_tokens.push_back(token);
}
}
- ASSERT(currentOffset ==
+ DCHECK(currentOffset ==
m_backingString.getCharacters<CharacterType>() +
m_backingString.length());
}
@@ -66,7 +66,7 @@ CSSVariableData::CSSVariableData(const CSSParserTokenRange& range,
: m_isAnimationTainted(isAnimationTainted),
m_needsVariableResolution(needsVariableResolution),
m_cachedPropertySet(false) {
- ASSERT(!range.atEnd());
+ DCHECK(!range.atEnd());
consumeAndUpdateTokens(range);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698