Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2662483002: Files app: Correct the order of file-list layer and empty-folder layer. (Closed)

Created:
3 years, 10 months ago by fukino
Modified:
3 years, 10 months ago
Reviewers:
yamaguchi
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Files app: Correct the order of file-list layer and empty-folder layer. The UI indicating that the folder is empty is behind the file-list layer. It used to be visible because the file-list has transparent background, but with https://codereview.chromium.org/2554433002, file-list got background color and the UI turned invisible. We should correct the order of layers instead of reverting the background color of file list, as the background color of file list is necessary to make use of native overlay scrollbar. BUG=685106 TEST=manually tested TBR=yamaguchi@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2652413002 Cr-Commit-Position: refs/heads/master@{#446280} (cherry picked from commit 1d0085691a3932c3e299c4af35f71e6e97dc3222) Review-Url: https://codereview.chromium.org/2662483002 . Cr-Commit-Position: refs/branch-heads/2987@{#124} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/2164fd8d8d0be849a16e5cec17ee2cd0a7995184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/file_manager/file_manager/main.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
3 years, 10 months ago (2017-01-26 23:15:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2164fd8d8d0be849a16e5cec17ee2cd0a7995184.

Powered by Google App Engine
This is Rietveld 408576698