Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 2662343003: Revert of Destroy MediaFileSystemRegistry before StorageMonitor in MTPDeviceDelegateImplWinTest. (Closed)

Created:
3 years, 10 months ago by tsergeant
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Lei Zhang, tommycli
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Destroy MediaFileSystemRegistry before StorageMonitor in MTPDeviceDelegateImplWinTest. (patchset #1 id:1 of https://codereview.chromium.org/2664073003/ ) Reason for revert: This CL is causing the test MTPDeviceDelegateImplWinTest.GalleryNameMTP to fail on Windows 7. See: https://luci-milo.appspot.com/buildbot/chromium.win/Win7%20Tests%20%281%29/63111 Original issue's description: > Destroy MediaFileSystemRegistry before StorageMonitor in MTPDeviceDelegateImplWinTest. > > MediaFileSystemRegistry must be destroyed before StorageMonitor > because it calls StorageMonitor::RemoveInstance in its destructor. > > It's not clear why this test isn't already failing on the waterfall. > A developer hit a failure when adding unrelated tests (see bug). > > BUG=686803 > > Review-Url: https://codereview.chromium.org/2664073003 > Cr-Commit-Position: refs/heads/master@{#447319} > Committed: https://chromium.googlesource.com/chromium/src/+/4efece94336e6bd0dccfc2772a6b0ab856aef84c TBR=reillyg@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686803 Review-Url: https://codereview.chromium.org/2662343003 Cr-Commit-Position: refs/heads/master@{#447351} Committed: https://chromium.googlesource.com/chromium/src/+/a09bd8e908a66bedfd344063695c7fd8ed10b6ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/media_galleries/win/mtp_device_delegate_impl_win_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
tsergeant
Created Revert of Destroy MediaFileSystemRegistry before StorageMonitor in MTPDeviceDelegateImplWinTest.
3 years, 10 months ago (2017-01-31 22:54:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662343003/1
3 years, 10 months ago (2017-01-31 22:56:07 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 23:01:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a09bd8e908a66bedfd344063695c...

Powered by Google App Engine
This is Rietveld 408576698