Chromium Code Reviews
DescriptionRevert of Destroy MediaFileSystemRegistry before StorageMonitor in MTPDeviceDelegateImplWinTest. (patchset #1 id:1 of https://codereview.chromium.org/2664073003/ )
Reason for revert:
This CL is causing the test MTPDeviceDelegateImplWinTest.GalleryNameMTP to fail on Windows 7. See:
https://luci-milo.appspot.com/buildbot/chromium.win/Win7%20Tests%20%281%29/63111
Original issue's description:
> Destroy MediaFileSystemRegistry before StorageMonitor in MTPDeviceDelegateImplWinTest.
>
> MediaFileSystemRegistry must be destroyed before StorageMonitor
> because it calls StorageMonitor::RemoveInstance in its destructor.
>
> It's not clear why this test isn't already failing on the waterfall.
> A developer hit a failure when adding unrelated tests (see bug).
>
> BUG=686803
>
> Review-Url: https://codereview.chromium.org/2664073003
> Cr-Commit-Position: refs/heads/master@{#447319}
> Committed: https://chromium.googlesource.com/chromium/src/+/4efece94336e6bd0dccfc2772a6b0ab856aef84c
TBR=reillyg@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686803
Review-Url: https://codereview.chromium.org/2662343003
Cr-Commit-Position: refs/heads/master@{#447351}
Committed: https://chromium.googlesource.com/chromium/src/+/a09bd8e908a66bedfd344063695c7fd8ed10b6ec
Patch Set 1 #
Messages
Total messages: 7 (4 generated)
|
|||||||||||||||||||