Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2664073003: Destroy MediaFileSystemRegistry before StorageMonitor in MTPDeviceDelegateImplWinTest. (Closed)

Created:
3 years, 10 months ago by fdoray
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Lei Zhang, tommycli
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Destroy MediaFileSystemRegistry before StorageMonitor in MTPDeviceDelegateImplWinTest. MediaFileSystemRegistry must be destroyed before StorageMonitor because it calls StorageMonitor::RemoveInstance in its destructor. It's not clear why this test isn't already failing on the waterfall. A developer hit a failure when adding unrelated tests (see bug). BUG=686803 Review-Url: https://codereview.chromium.org/2664073003 Cr-Commit-Position: refs/heads/master@{#447319} Committed: https://chromium.googlesource.com/chromium/src/+/4efece94336e6bd0dccfc2772a6b0ab856aef84c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/media_galleries/win/mtp_device_delegate_impl_win_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
fdoray
PTAL
3 years, 10 months ago (2017-01-31 18:47:45 UTC) #8
Reilly Grant (use Gerrit)
lgtm
3 years, 10 months ago (2017-01-31 20:36:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664073003/1
3 years, 10 months ago (2017-01-31 20:37:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/4efece94336e6bd0dccfc2772a6b0ab856aef84c
3 years, 10 months ago (2017-01-31 20:43:26 UTC) #14
tsergeant
3 years, 10 months ago (2017-01-31 22:54:58 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2662343003/ by tsergeant@chromium.org.

The reason for reverting is: This CL is causing the test
MTPDeviceDelegateImplWinTest.GalleryNameMTP to fail on Windows 7. See:

https://luci-milo.appspot.com/buildbot/chromium.win/Win7%20Tests%20%281%29/63111.

Powered by Google App Engine
This is Rietveld 408576698