Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2662323002: Revert of Drop .clang-format in ui/webui now that Chromium JS defaults are the same (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Drop .clang-format in ui/webui now that Chromium JS defaults are the same (patchset #1 id:1 of https://codereview.chromium.org/2664613002/ ) Reason for revert: clang-format binaries were reverted, so the defaults are not as good at the moment. Original issue's description: > Drop .clang-format in ui/webui now that Chromium JS defaults are the same > > Additionally, grit now deals with ' as well as " in <include> and <if>. > > R=dpapad@chromium.org > BUG=567770 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2664613002 > Cr-Commit-Position: refs/heads/master@{#447126} > Committed: https://chromium.googlesource.com/chromium/src/+/9fb56fe502090f3cf70b4c531b763c7ba82937ee TBR=dpapad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=567770 Review-Url: https://codereview.chromium.org/2662323002 Cr-Commit-Position: refs/heads/master@{#447284} Committed: https://chromium.googlesource.com/chromium/src/+/f0728f745fd97872e37e3b0fedb47264a7c6df13

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
A chrome/browser/resources/.clang-format View 1 chunk +8 lines, -0 lines 0 comments Download
A ui/webui/resources/.clang-format View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_scrollable_behavior.js View 1 chunk +1 line, -2 lines 0 comments Download
M ui/webui/resources/js/analytics.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/bubble.js View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/webui/resources/js/jstemplate_compiled.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Dan Beam
Created Revert of Drop .clang-format in ui/webui now that Chromium JS defaults are the same
3 years, 10 months ago (2017-01-31 19:00:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662323002/1
3 years, 10 months ago (2017-01-31 19:01:54 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 19:04:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0728f745fd97872e37e3b0fedb4...

Powered by Google App Engine
This is Rietveld 408576698