Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2664613002: Drop .clang-format in ui/webui now that Chromium JS defaults are the same (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop .clang-format in ui/webui now that Chromium JS defaults are the same Additionally, grit now deals with ' as well as " in <include> and <if>. R=dpapad@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2664613002 Cr-Commit-Position: refs/heads/master@{#447126} Committed: https://chromium.googlesource.com/chromium/src/+/9fb56fe502090f3cf70b4c531b763c7ba82937ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
D chrome/browser/resources/.clang-format View 1 chunk +0 lines, -8 lines 0 comments Download
D ui/webui/resources/.clang-format View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_scrollable_behavior.js View 1 chunk +2 lines, -1 line 0 comments Download
M ui/webui/resources/js/analytics.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/bubble.js View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/webui/resources/js/jstemplate_compiled.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Dan Beam
3 years, 10 months ago (2017-01-30 19:07:35 UTC) #2
dpapad
lgtm
3 years, 10 months ago (2017-01-30 21:48:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664613002/1
3 years, 10 months ago (2017-01-31 00:18:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9fb56fe502090f3cf70b4c531b763c7ba82937ee
3 years, 10 months ago (2017-01-31 00:24:28 UTC) #12
Dan Beam
3 years, 10 months ago (2017-01-31 19:00:54 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2662323002/ by dbeam@chromium.org.

The reason for reverting is: clang-format binaries were reverted, so the
defaults are not as good at the moment..

Powered by Google App Engine
This is Rietveld 408576698