Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2662203002: CSS: Rotate support for none and fixed responsive-test.js (Closed)

Created:
3 years, 10 months ago by Eric Willigers
Modified:
3 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, divyanshi, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS: Rotate support for none and fixed responsive-test.js The initial value for rotate is none not 0deg. https://drafts.csswg.org/css-transforms-2/#individual-transforms Responsive test was not checking that the property value was valid. Also added a parsing test for scale. Patch by divyanshi@google.com https://codereview.chromium.org/2625313002/ Interpolation and composition expectations added. BUG=679873 Review-Url: https://codereview.chromium.org/2662203002 Cr-Commit-Position: refs/heads/master@{#448751} Committed: https://chromium.googlesource.com/chromium/src/+/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668

Patch Set 1 #

Patch Set 2 : avoid expectation failure on Mac #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -28 lines) Patch
M third_party/WebKit/LayoutTests/animations/composition/rotate-composition.html View 1 chunk +56 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/rotate-interpolation.html View 1 3 chunks +20 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/interpolation/rotate-interpolation-expected.txt View 1 1 chunk +202 lines, -0 lines 1 comment Download
M third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/rotate-responsive.html View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/transform-responsive.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/transforms/rotate-parsing.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/transforms/scale-parsing.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
Eric Willigers
https://codereview.chromium.org/2662203002/diff/20001/third_party/WebKit/LayoutTests/animations/interpolation/rotate-interpolation-expected.txt File third_party/WebKit/LayoutTests/animations/interpolation/rotate-interpolation-expected.txt (right): https://codereview.chromium.org/2662203002/diff/20001/third_party/WebKit/LayoutTests/animations/interpolation/rotate-interpolation-expected.txt#newcode122 third_party/WebKit/LayoutTests/animations/interpolation/rotate-interpolation-expected.txt:122: PASS CSS Animations: property <rotate> from [1 1 0 ...
3 years, 10 months ago (2017-01-31 18:58:21 UTC) #8
Eric Willigers
Note the CSS Animations and Web Animations currently fail in giving 0deg instead of none. ...
3 years, 10 months ago (2017-02-02 16:30:20 UTC) #12
sashab
lgtm
3 years, 10 months ago (2017-02-07 04:31:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662203002/20001
3 years, 10 months ago (2017-02-07 06:04:32 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/148540)
3 years, 10 months ago (2017-02-07 06:07:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662203002/20001
3 years, 10 months ago (2017-02-07 21:06:50 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 22:40:12 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7f3c2b8170c9058511d39135cfa1...

Powered by Google App Engine
This is Rietveld 408576698