Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 2662203002: CSS: Rotate support for none and fixed responsive-test.js (Closed)
Patch Set: avoid expectation failure on Mac Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
index 16a2d9d10eb4c2e2898046b7f3bc71e7604dbbaf..8462cb668bf409ad52c09d9971d5f5e75d98faff 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
@@ -1287,6 +1287,11 @@ PassRefPtr<TranslateTransformOperation> StyleBuilderConverter::convertTranslate(
}
Rotation StyleBuilderConverter::convertRotation(const CSSValue& value) {
+ if (value.isIdentifierValue()) {
+ DCHECK_EQ(toCSSIdentifierValue(value).getValueID(), CSSValueNone);
+ return Rotation(FloatPoint3D(0, 0, 1), 0);
+ }
+
const CSSValueList& list = toCSSValueList(value);
ASSERT(list.length() == 1 || list.length() == 4);
double x = 0;
@@ -1305,6 +1310,11 @@ Rotation StyleBuilderConverter::convertRotation(const CSSValue& value) {
PassRefPtr<RotateTransformOperation> StyleBuilderConverter::convertRotate(
StyleResolverState& state,
const CSSValue& value) {
+ if (value.isIdentifierValue()) {
+ DCHECK_EQ(toCSSIdentifierValue(value).getValueID(), CSSValueNone);
+ return nullptr;
+ }
+
return RotateTransformOperation::create(convertRotation(value),
TransformOperation::Rotate3D);
}

Powered by Google App Engine
This is Rietveld 408576698