Always get device conditions from Java for every attempt.
Previously we used the NetworkChangeNotifier, but it does not
get network change notifications when Chrome runs in the background,
which is our primary use case. So, before starting each request,
get the latest device conditions from Android directly via the Java
API.
BUG=682790
Review-Url: https://codereview.chromium.org/2659813006
Cr-Commit-Position: refs/heads/master@{#447201}
(cherry picked from commit a2c4dd1ab5ba1423bdb46bd4b0111b942ad5f3fb)
Review-Url: https://codereview.chromium.org/2662103003 .
Cr-Commit-Position: refs/branch-heads/2987@{#231}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/0df272278a6e96e7a6250047260cbc236844d16c
Description was changed from ========== Always get device conditions from Java for every attempt. Previously ...
3 years, 10 months ago
(2017-01-31 20:30:14 UTC)
#1
Description was changed from
==========
Always get device conditions from Java for every attempt.
Previously we used the NetworkChangeNotifier, but it does not
get network change notifications when Chrome runs in the background,
which is our primary use case. So, before starting each request,
get the latest device conditions from Android directly via the Java
API.
BUG=682790
Review-Url: https://codereview.chromium.org/2659813006
Cr-Commit-Position: refs/heads/master@{#447201}
(cherry picked from commit a2c4dd1ab5ba1423bdb46bd4b0111b942ad5f3fb)
==========
to
==========
Always get device conditions from Java for every attempt.
Previously we used the NetworkChangeNotifier, but it does not
get network change notifications when Chrome runs in the background,
which is our primary use case. So, before starting each request,
get the latest device conditions from Android directly via the Java
API.
BUG=682790
Review-Url: https://codereview.chromium.org/2659813006
Cr-Commit-Position: refs/heads/master@{#447201}
(cherry picked from commit a2c4dd1ab5ba1423bdb46bd4b0111b942ad5f3fb)
Review-Url: https://codereview.chromium.org/2662103003 .
Cr-Commit-Position: refs/branch-heads/2987@{#231}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/0df272278a6e96e7a6250047260c...
==========
Pete Williamson
Committed patchset #1 (id:1) manually as 0df272278a6e96e7a6250047260cbc236844d16c.
3 years, 10 months ago
(2017-01-31 20:30:15 UTC)
#2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0df272278a6e96e7a6250047260cbc236844d16c.
Issue 2662103003: Always get device conditions from Java for every attempt.
(Closed)
Created 3 years, 10 months ago by Pete Williamson
Modified 3 years, 10 months ago
Reviewers:
Base URL:
Comments: 0