Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2662103003: Always get device conditions from Java for every attempt. (Closed)

Created:
3 years, 10 months ago by Pete Williamson
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Always get device conditions from Java for every attempt. Previously we used the NetworkChangeNotifier, but it does not get network change notifications when Chrome runs in the background, which is our primary use case. So, before starting each request, get the latest device conditions from Android directly via the Java API. BUG=682790 Review-Url: https://codereview.chromium.org/2659813006 Cr-Commit-Position: refs/heads/master@{#447201} (cherry picked from commit a2c4dd1ab5ba1423bdb46bd4b0111b942ad5f3fb) Review-Url: https://codereview.chromium.org/2662103003 . Cr-Commit-Position: refs/branch-heads/2987@{#231} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/0df272278a6e96e7a6250047260cbc236844d16c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -89 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/background_scheduler_bridge.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/background_scheduler_bridge.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/evaluation/evaluation_test_scheduler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/evaluation/evaluation_test_scheduler.cc View 4 chunks +17 lines, -5 lines 0 comments Download
M chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator.h View 6 chunks +8 lines, -16 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator.cc View 8 chunks +36 lines, -33 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator_unittest.cc View 13 chunks +28 lines, -26 lines 0 comments Download
M components/offline_pages/core/background/scheduler.h View 2 chunks +5 lines, -0 lines 0 comments Download
M components/offline_pages/core/background/scheduler_stub.h View 1 chunk +9 lines, -2 lines 0 comments Download
M components/offline_pages/core/background/scheduler_stub.cc View 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Pete Williamson
3 years, 10 months ago (2017-01-31 20:30:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0df272278a6e96e7a6250047260cbc236844d16c.

Powered by Google App Engine
This is Rietveld 408576698