Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2662103003: Always get device conditions from Java for every attempt. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h" 5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h"
6 6
7 #include "base/android/callback_android.h" 7 #include "base/android/callback_android.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 } 286 }
287 287
288 bool OfflinePageEvaluationBridge::PushRequestProcessing( 288 bool OfflinePageEvaluationBridge::PushRequestProcessing(
289 JNIEnv* env, 289 JNIEnv* env,
290 const JavaParamRef<jobject>& obj, 290 const JavaParamRef<jobject>& obj,
291 const JavaParamRef<jobject>& j_callback_obj) { 291 const JavaParamRef<jobject>& j_callback_obj) {
292 ScopedJavaGlobalRef<jobject> j_callback_ref(j_callback_obj); 292 ScopedJavaGlobalRef<jobject> j_callback_ref(j_callback_obj);
293 DCHECK(request_coordinator_); 293 DCHECK(request_coordinator_);
294 base::android::RunCallbackAndroid(j_callback_obj, false); 294 base::android::RunCallbackAndroid(j_callback_obj, false);
295 295
296 net::NetworkChangeNotifier::ConnectionType connection =
297 net::NetworkChangeNotifier::GetConnectionType();
298 DeviceConditions device_conditions(false, 0, connection);
299 return request_coordinator_->StartImmediateProcessing( 296 return request_coordinator_->StartImmediateProcessing(
300 device_conditions, base::Bind(&OnPushRequestsDone, j_callback_ref)); 297 base::Bind(&OnPushRequestsDone, j_callback_ref));
301 } 298 }
302 299
303 void OfflinePageEvaluationBridge::SavePageLater( 300 void OfflinePageEvaluationBridge::SavePageLater(
304 JNIEnv* env, 301 JNIEnv* env,
305 const JavaParamRef<jobject>& obj, 302 const JavaParamRef<jobject>& obj,
306 const JavaParamRef<jstring>& j_url, 303 const JavaParamRef<jstring>& j_url,
307 const JavaParamRef<jstring>& j_namespace, 304 const JavaParamRef<jstring>& j_namespace,
308 const JavaParamRef<jstring>& j_client_id, 305 const JavaParamRef<jstring>& j_client_id,
309 jboolean user_requested) { 306 jboolean user_requested) {
310 offline_pages::ClientId client_id; 307 offline_pages::ClientId client_id;
(...skipping 29 matching lines...) Expand all
340 337
341 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const { 338 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const {
342 if (!offline_page_model_->is_loaded()) 339 if (!offline_page_model_->is_loaded())
343 return; 340 return;
344 JNIEnv* env = base::android::AttachCurrentThread(); 341 JNIEnv* env = base::android::AttachCurrentThread();
345 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_); 342 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_);
346 } 343 }
347 344
348 } // namespace android 345 } // namespace android
349 } // namespace offline_pages 346 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698