Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2662043002: [Merge M-57] Relax card type handling. (Closed)

Created:
3 years, 10 months ago by please use gerrit instead
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge M-57] Relax card type handling. Chrome does not yet differentiate between the various `supportedTypes` ['credit', 'debit', 'prepaid'] in `PaymentMethodData.data`. To warn developers of this behavior, we now allow `supportedTypes` with 1 or 2 arguments and show a warning message in developer console instead: "Cannot yet distinguish credit, debit, and prepaid cards." BUG=686119 Review-Url: https://codereview.chromium.org/2659083003 Cr-Commit-Position: refs/heads/master@{#446996} (cherry picked from commit 06a0d2103e3207a176f4b3b98537106854a4ec00) Review-Url: https://codereview.chromium.org/2662043002 . Cr-Commit-Position: refs/branch-heads/2987@{#184} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/06a557a4c7c5bfdb7bfd3ad058d6f9179464d08b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -230 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java View 2 chunks +5 lines, -26 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBasicCardTest.java View 2 chunks +14 lines, -6 lines 0 comments Download
M chrome/test/data/payments/basic_card.js View 6 chunks +115 lines, -189 lines 0 comments Download
M chrome/test/data/payments/payment_request_basic_card_test.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 13 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
please use gerrit instead
3 years, 10 months ago (2017-01-30 20:52:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06a557a4c7c5bfdb7bfd3ad058d6f9179464d08b.

Powered by Google App Engine
This is Rietveld 408576698