Relax card type handling.

Relax card type handling.

Chrome does not yet differentiate between the various `supportedTypes`
['credit', 'debit', 'prepaid'] in `PaymentMethodData.data`. To warn
developers of this behavior, we now allow `supportedTypes` with 1 or 2
arguments and show a warning message in developer console instead:
"Cannot yet distinguish credit, debit, and prepaid cards."

BUG=686119
Review-Url: https://codereview.chromium.org/2659083003
Cr-Commit-Position: refs/heads/master@{#446996}
Committed: https://chromium.googlesource.com/chromium/src/+/06a0d2103e3207a176f4b3b98537106854a4ec00

[please use gerrit instead, 2017-01-27 16:39:19]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 16:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-01-27 16:50:38]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 16:51:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-01-27 17:30:15]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-01-27 18:57:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:57:30]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-01-28 01:01:39]

rouslan@chromium.org changed reviewers:
+ mathp@chromium.org

[please use gerrit instead, 2017-01-28 01:01:40]

Mathieu, PTAL.

[Mathieu, 2017-01-28 01:58:57]

lgtm

The wording of the description is a bit confusing.
How about:

Chrome does not yet differentiate between the various `supportedTypes`
['credit', 'debit', 'prepaid'] in `PaymentMethodData.data`. To warn developers
of this behavior, we now allow `supportedTypes` with 1 or 2 arguments and show a
warning message in developer console instead: "Cannot yet distinguish credit,
debit, and prepaid cards."

https://codereview.chromium.org/2659083003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
(right):

https://codereview.chromium.org/2659083003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java:93:
// No issuer networks are supported.
Could we add "by the [merchant,website]" (whichever you prefer) to the three
comments here?

Otherwise I find the comments confusing, as it's unclear it's supported by who.

[please use gerrit instead, 2017-01-30 14:50:23]

Description was changed from

==========
Relax card type handling.

Adding `supportedTypes` in `PaymentMethodData.data` will cause a
rejection unless it has all 3 types 'credit', 'debit' and 'prepaid'.
Otherwise devs should completely remove `supportedTypes`. This will
cause a confusion and extra work for developers in the future. So we
should allow `supportedTypes` with 1 or 2 arguments and show a warning
message in developer console instead: "Cannot yet distinguish credit,
debit, and prepaid cards."

BUG=686119
==========

to

==========
Relax card type handling.

Chrome does not yet differentiate between the various `supportedTypes`
['credit', 'debit', 'prepaid'] in `PaymentMethodData.data`. To warn
developers of this behavior, we now allow `supportedTypes` with 1 or 2
arguments and show a warning message in developer console instead:
"Cannot yet distinguish credit, debit, and prepaid cards."

BUG=686119
==========

[please use gerrit instead, 2017-01-30 14:52:04]

https://codereview.chromium.org/2659083003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
(right):

https://codereview.chromium.org/2659083003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java:93:
// No issuer networks are supported.
On 2017/01/28 01:58:57, Mathieu Perreault wrote:
> Could we add "by the [merchant,website]" (whichever you prefer) to the three
> comments here?
> 
> Otherwise I find the comments confusing, as it's unclear it's supported by
who. 

Done.

[please use gerrit instead, 2017-01-30 14:52:14]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-01-30 14:52:14]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2659083003/#ps40001
(title: "Clarify comment")

[commit-bot: I haz the power, 2017-01-30 14:52:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 16:34:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485787934253870,
"parent_rev": "1d4a57bb57953581956932dfd3578d0bdd432692", "commit_rev":
"06a0d2103e3207a176f4b3b98537106854a4ec00"}

[commit-bot: I haz the power, 2017-01-30 16:34:50]

Description was changed from

==========
Relax card type handling.

Chrome does not yet differentiate between the various `supportedTypes`
['credit', 'debit', 'prepaid'] in `PaymentMethodData.data`. To warn
developers of this behavior, we now allow `supportedTypes` with 1 or 2
arguments and show a warning message in developer console instead:
"Cannot yet distinguish credit, debit, and prepaid cards."

BUG=686119
==========

to

==========
Relax card type handling.

Chrome does not yet differentiate between the various `supportedTypes`
['credit', 'debit', 'prepaid'] in `PaymentMethodData.data`. To warn
developers of this behavior, we now allow `supportedTypes` with 1 or 2
arguments and show a warning message in developer console instead:
"Cannot yet distinguish credit, debit, and prepaid cards."

BUG=686119

Review-Url: https://codereview.chromium.org/2659083003
Cr-Commit-Position: refs/heads/master@{#446996}
Committed:
https://chromium.googlesource.com/chromium/src/+/06a0d2103e3207a176f4b3b98537...
==========

[commit-bot: I haz the power, 2017-01-30 16:34:51]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/06a0d2103e3207a176f4b3b98537...