Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2659083003: Relax card type handling. (Closed)

Created:
3 years, 10 months ago by please use gerrit instead
Modified:
3 years, 10 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, haraken, rouslan+payments_chromium.org, agrieve+watch_chromium.org, blink-reviews, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relax card type handling. Chrome does not yet differentiate between the various `supportedTypes` ['credit', 'debit', 'prepaid'] in `PaymentMethodData.data`. To warn developers of this behavior, we now allow `supportedTypes` with 1 or 2 arguments and show a warning message in developer console instead: "Cannot yet distinguish credit, debit, and prepaid cards." BUG=686119 Review-Url: https://codereview.chromium.org/2659083003 Cr-Commit-Position: refs/heads/master@{#446996} Committed: https://chromium.googlesource.com/chromium/src/+/06a0d2103e3207a176f4b3b98537106854a4ec00

Patch Set 1 : Update comment #

Total comments: 2

Patch Set 2 : Clarify comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -230 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java View 1 2 chunks +5 lines, -26 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBasicCardTest.java View 2 chunks +14 lines, -6 lines 0 comments Download
M chrome/test/data/payments/basic_card.js View 6 chunks +115 lines, -189 lines 0 comments Download
M chrome/test/data/payments/payment_request_basic_card_test.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 13 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
please use gerrit instead
Mathieu, PTAL.
3 years, 10 months ago (2017-01-28 01:01:40 UTC) #9
Mathieu
lgtm The wording of the description is a bit confusing. How about: Chrome does not ...
3 years, 10 months ago (2017-01-28 01:58:57 UTC) #10
please use gerrit instead
https://codereview.chromium.org/2659083003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java File chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java (right): https://codereview.chromium.org/2659083003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java#newcode93 chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java:93: // No issuer networks are supported. On 2017/01/28 01:58:57, ...
3 years, 10 months ago (2017-01-30 14:52:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659083003/40001
3 years, 10 months ago (2017-01-30 14:52:25 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 16:34:51 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/06a0d2103e3207a176f4b3b98537...

Powered by Google App Engine
This is Rietveld 408576698