Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Issue 266193003: Revert of Fix to remove customised String over IPC for SmartClip (Closed)

Created:
6 years, 7 months ago by loislo
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Fix to remove customised String over IPC for SmartClip (https://codereview.chromium.org/259263003/) Reason for revert: android build was broken by this patch http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/39026/steps/compile/logs/stdio Original issue's description: > Fix to remove customised String over IPC for SmartClip > > Currently, the data for SmartClip is sent over IPC as a customized > string, which contains rect values and string of content within the > clip rect. Changes from Blink side to remove custom serialization and > send it as a structure of rect and string values. > > BUG=330872 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173295 TBR=eseidel@chromium.org,juhui24.lee@samsung.com,abarth@chromium.org,jam@chromium.org,jschuh@chromium.org,ch.dumez@samsung.com,avi.nitk@samsung.com NOTREECHECKS=true NOTRY=true BUG=330872 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -22 lines) Patch
M Source/core/frame/SmartClip.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/frame/SmartClip.cpp View 1 chunk +27 lines, -8 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M public/web/WebView.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
loislo
Created Revert of Fix to remove customised String over IPC for SmartClip
6 years, 7 months ago (2014-05-05 12:14:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/266193003/1
6 years, 7 months ago (2014-05-05 12:14:43 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 12:15:15 UTC) #3
Message was sent while issue was closed.
Change committed as 173296

Powered by Google App Engine
This is Rietveld 408576698