Source/web/WebViewImpl.cpp - Issue 266193003: Revert of Fix to remove customised String over IPC for SmartClip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 266193003: Revert of Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 5826744778f787182ffe7b3158cb5c133390a569..49d7d856386626019610524410de56813ca5c3c2 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -3448,14 +3448,12 @@

m_contextMenuAllowed = false;

}

-void WebViewImpl::getSmartClipData(WebRect rect, WebString* clipText, WebRect* clipRect)

+WebString WebViewImpl::getSmartClipData(WebRect rect)

{

LocalFrame* frame = toLocalFrame(focusedWebCoreFrame());

if (!frame)

- return;

- SmartClipData clipData = WebCore::SmartClip(frame).dataForRect(rect);

- *clipText = clipData.getClipData();

- *clipRect = clipData.getRect();

+ return WebString();

+ return WebCore::SmartClip(frame).dataForRect(rect).toString();

}

void WebViewImpl::hidePopups()

« no previous file with comments | « Source/web/WebViewImpl.h ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »