Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2661913002: Identity extension API impl: Split constants into their own file (Closed)

Created:
3 years, 10 months ago by blundell
Modified:
3 years, 10 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Identity extension API impl: Split constants into their own file As part of the process of making the individual identity extension API function impls easier to analyze in isolation, this CL splits constants out of identity_api.* into their own separate file. Doing so makes it clear (1) which files actually need IdentityAPI and (2) which other dependencies these files need (since identity_api.h has a fairly large transitive set of includes). BUG=685654 Review-Url: https://codereview.chromium.org/2661913002 Cr-Commit-Position: refs/heads/master@{#447467} Committed: https://chromium.googlesource.com/chromium/src/+/a13e60415f37f21ededa42c9d1298813f92ed2ec

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
blundell
3 years, 10 months ago (2017-01-31 08:40:32 UTC) #6
Ken Rockot(use gerrit already)
lgtm
3 years, 10 months ago (2017-01-31 21:12:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661913002/1
3 years, 10 months ago (2017-02-01 06:16:41 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 07:17:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a13e60415f37f21ededa42c9d129...

Powered by Google App Engine
This is Rietveld 408576698