Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/browser/extensions/api/identity/identity_api.cc

Issue 2661913002: Identity extension API impl: Split constants into their own file (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/identity/identity_api.cc
diff --git a/chrome/browser/extensions/api/identity/identity_api.cc b/chrome/browser/extensions/api/identity/identity_api.cc
index d10409bc48794e96db1dc4dab31eef19c11f774a..81d003ea387043f2d50c06cfc7193dc68fbf03ae 100644
--- a/chrome/browser/extensions/api/identity/identity_api.cc
+++ b/chrome/browser/extensions/api/identity/identity_api.cc
@@ -23,6 +23,7 @@
#include "chrome/browser/app_mode/app_mode_utils.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/extensions/api/identity/identity_constants.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/signin/account_tracker_service_factory.h"
@@ -57,22 +58,6 @@
namespace extensions {
-namespace identity_constants {
-const char kInvalidClientId[] = "Invalid OAuth2 Client ID.";
-const char kInvalidScopes[] = "Invalid OAuth2 scopes.";
-const char kAuthFailure[] = "OAuth2 request failed: ";
-const char kNoGrant[] = "OAuth2 not granted or revoked.";
-const char kUserRejected[] = "The user did not approve access.";
-const char kUserNotSignedIn[] = "The user is not signed in.";
-const char kInteractionRequired[] = "User interaction required.";
-const char kInvalidRedirect[] = "Did not redirect to the right URL.";
-const char kOffTheRecord[] = "Identity API is disabled in incognito windows.";
-const char kPageLoadFailure[] = "Authorization page could not be loaded.";
-const char kCanceled[] = "canceled";
-
-const int kCachedIssueAdviceTTLSeconds = 1;
-} // namespace identity_constants
-
namespace {
#if defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/extensions/api/identity/identity_api.h ('k') | chrome/browser/extensions/api/identity/identity_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698