ARC IME: Fix Crash on ARC Notification

ARC IME: Fix Crash on ARC Notification

This CL adds a handler of WindowObserver::OnWindowRemovingFromRootWindow to detach IME. This fixes the crash which has been introduced by crbug.com/685724.

And this CL also changes |focused_arc_window_| property from a aura::WindowTracker to a raw pointer for visibility.

BUG=685724
TEST=manually (crash doesn't happen)

Review-Url: https://codereview.chromium.org/2661863002
Cr-Commit-Position: refs/heads/master@{#447458}
Committed: https://chromium.googlesource.com/chromium/src/+/f00d3c2b8f462741503a9da7881129658ebcbc09

[yoshiki, 2017-01-30 08:40:54]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 08:41:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 09:12:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 09:12:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2017-01-31 04:57:19]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 04:57:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2017-01-31 05:03:12]

Description was changed from

==========
wip

.

BUG=
==========

to

==========
ARC IME: Fix Crash on ARC Notification

This CL adds a handler of WindowObserver::OnWindowRemovingFromRootWindow to
detach IME. This fixes the crash which has been introduced by crbug.com/685724.

And this CL also changes |focused_arc_window_| property from a
aura::WindowTracker to a raw pointer for visibility.

BUG=685724
TEST=manually (crash doesn't happen)
==========

[yoshiki, 2017-01-31 05:03:12]

yoshiki@chromium.org changed reviewers:
+ kinaba@chromium.org

[yoshiki, 2017-01-31 05:03:42]

kinaba-san, PTAL.

[commit-bot: I haz the power, 2017-01-31 05:27:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 05:27:05]

Dry run: This issue passed the CQ dry run.

[kinaba, 2017-01-31 07:36:35]

lgtm

[yoshiki, 2017-01-31 07:54:56]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2017-01-31 07:55:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 08:00:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 08:00:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoshiki, 2017-02-01 04:05:39]

yoshiki@chromium.org changed reviewers:
+ hidehiko@chromium.org

[yoshiki, 2017-02-01 04:05:39]

Hidehiko-san, PTAL

[hidehiko, 2017-02-01 04:12:35]

lgtm

https://codereview.chromium.org/2661863002/diff/20001/components/arc/ime/arc_...
File components/arc/ime/arc_ime_service.cc (right):

https://codereview.chromium.org/2661863002/diff/20001/components/arc/ime/arc_...
components/arc/ime/arc_ime_service.cc:240: new_bounds,
window->layer()->device_scale_factor());
nit: you can inline |focused_arc_window_| here.

[kinaba, 2017-02-01 04:13:27]

one more nit

https://codereview.chromium.org/2661863002/diff/20001/components/arc/ime/arc_...
File components/arc/ime/arc_ime_service.h (right):

https://codereview.chromium.org/2661863002/diff/20001/components/arc/ime/arc_...
components/arc/ime/arc_ime_service.h:16: #include "ui/aura/window_tracker.h"
not needed?

[yoshiki, 2017-02-01 05:04:29]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2017-02-01 05:04:30]

The CQ bit was unchecked by yoshiki@chromium.org

[yoshiki, 2017-02-01 05:09:13]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 05:09:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2017-02-01 05:10:10]

https://codereview.chromium.org/2661863002/diff/20001/components/arc/ime/arc_...
File components/arc/ime/arc_ime_service.h (right):

https://codereview.chromium.org/2661863002/diff/20001/components/arc/ime/arc_...
components/arc/ime/arc_ime_service.h:16: #include "ui/aura/window_tracker.h"
On 2017/02/01 04:13:27, kinaba wrote:
> not needed?

Removed.

[commit-bot: I haz the power, 2017-02-01 05:37:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 05:37:43]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-02-01 05:44:17]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2017-02-01 05:44:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, kinaba@chromium.org
Link to the patchset: https://codereview.chromium.org/2661863002/#ps40001
(title: "Removed unnecessary include")

[commit-bot: I haz the power, 2017-02-01 05:44:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 05:48:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485927857985970,
"parent_rev": "95948d4ee56a43c688ad9bc2975b1eff1376e2c0", "commit_rev":
"f00d3c2b8f462741503a9da7881129658ebcbc09"}

[commit-bot: I haz the power, 2017-02-01 05:48:59]

Description was changed from

==========
ARC IME: Fix Crash on ARC Notification

This CL adds a handler of WindowObserver::OnWindowRemovingFromRootWindow to
detach IME. This fixes the crash which has been introduced by crbug.com/685724.

And this CL also changes |focused_arc_window_| property from a
aura::WindowTracker to a raw pointer for visibility.

BUG=685724
TEST=manually (crash doesn't happen)
==========

to

==========
ARC IME: Fix Crash on ARC Notification

This CL adds a handler of WindowObserver::OnWindowRemovingFromRootWindow to
detach IME. This fixes the crash which has been introduced by crbug.com/685724.

And this CL also changes |focused_arc_window_| property from a
aura::WindowTracker to a raw pointer for visibility.

BUG=685724
TEST=manually (crash doesn't happen)

Review-Url: https://codereview.chromium.org/2661863002
Cr-Commit-Position: refs/heads/master@{#447458}
Committed:
https://chromium.googlesource.com/chromium/src/+/f00d3c2b8f462741503a9da78811...
==========

[commit-bot: I haz the power, 2017-02-01 05:49:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f00d3c2b8f462741503a9da78811...