Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2427)

Unified Diff: components/arc/ime/arc_ime_service.h

Issue 2661863002: ARC IME: Fix Crash on ARC Notification (Closed)
Patch Set: Removed unnecessary include Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/arc/ime/arc_ime_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/ime/arc_ime_service.h
diff --git a/components/arc/ime/arc_ime_service.h b/components/arc/ime/arc_ime_service.h
index 86784b764f37c00ba7f831381153e01392a8650e..8fc29e38c0471d2c65b1be3a6e9a0f399ee04023 100644
--- a/components/arc/ime/arc_ime_service.h
+++ b/components/arc/ime/arc_ime_service.h
@@ -13,7 +13,6 @@
#include "components/exo/wm_helper.h"
#include "ui/aura/env_observer.h"
#include "ui/aura/window_observer.h"
-#include "ui/aura/window_tracker.h"
#include "ui/base/ime/text_input_client.h"
#include "ui/base/ime/text_input_flags.h"
#include "ui/base/ime/text_input_type.h"
@@ -38,6 +37,7 @@ class ArcBridgeService;
class ArcImeService : public ArcService,
public ArcImeBridge::Delegate,
public aura::EnvObserver,
+ public aura::WindowObserver,
public exo::WMHelper::FocusObserver,
public keyboard::KeyboardControllerObserver,
public ui::TextInputClient {
@@ -66,6 +66,11 @@ class ArcImeService : public ArcService,
// Overridden from aura::EnvObserver:
void OnWindowInitialized(aura::Window* new_window) override;
+ // Overridden from aura::WindowObserver:
+ void OnWindowDestroying(aura::Window* window) override;
+ void OnWindowRemovingFromRootWindow(aura::Window* window,
+ aura::Window* new_root) override;
+
// Overridden from exo::WMHelper::FocusObserver:
void OnWindowFocused(aura::Window* gained_focus,
aura::Window* lost_focus) override;
@@ -124,7 +129,7 @@ class ArcImeService : public ArcService,
gfx::Rect cursor_rect_;
bool has_composition_text_;
- aura::WindowTracker focused_arc_window_;
+ aura::Window* focused_arc_window_ = nullptr;
keyboard::KeyboardController* keyboard_controller_;
« no previous file with comments | « no previous file | components/arc/ime/arc_ime_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698