third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

index 2ece4781b937e0ce01771ff8f3066633352acfc6..3ccc62e5235c08ee993f3ccbce31202f9a91939a 100644

--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

@@ -405,9 +405,12 @@ void FrameLoaderClientImpl::dispatchWillCommitProvisionalLoad() {

m_webFrame->client()->willCommitProvisionalLoad(m_webFrame);

}

-void FrameLoaderClientImpl::dispatchDidStartProvisionalLoad() {

- if (m_webFrame->client())

- m_webFrame->client()->didStartProvisionalLoad(m_webFrame);

+void FrameLoaderClientImpl::dispatchDidStartProvisionalLoad(

+ DocumentLoader* loader) {

+ if (m_webFrame->client()) {

+ m_webFrame->client()->didStartProvisionalLoad(

+ WebDataSourceImpl::fromDocumentLoader(loader));

+ }

if (WebDevToolsAgentImpl* devTools = devToolsAgent())

devTools->didStartProvisionalLoad(m_webFrame->frame());

}