third_party/WebKit/Source/web/FrameLoaderClientImpl.h - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.h

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.h

diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.h b/third_party/WebKit/Source/web/FrameLoaderClientImpl.h

index 4374262edba212b1d2de06c32b9a8f12a277dfc0..bede8e1f29a240d2c1e865a3e2497909910192b8 100644

--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.h

+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.h

@@ -92,7 +92,7 @@ class FrameLoaderClientImpl final : public FrameLoaderClient {

HistoryCommitType,

bool contentInitiated) override;

void dispatchWillCommitProvisionalLoad() override;

- void dispatchDidStartProvisionalLoad() override;

+ void dispatchDidStartProvisionalLoad(DocumentLoader*) override;

void dispatchDidReceiveTitle(const String&) override;

void dispatchDidChangeIcons(IconType) override;

void dispatchDidCommitLoad(HistoryItem*, HistoryCommitType) override;