Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)
Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp b/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
index 2d83ecac33a357af80b84d3a09b0162b37479856..0e67bc74d2b34001ea4e2e9b5b970443a0915b10 100644
--- a/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
@@ -49,14 +49,13 @@ class TestDocumentSubresourceFilter : public WebDocumentSubresourceFilter {
class SubresourceFilteringWebFrameClient
: public FrameTestHelpers::TestWebFrameClient {
public:
- void didStartProvisionalLoad(WebLocalFrame* localFrame) override {
+ void didStartProvisionalLoad(WebDataSource* dataSource) override {
// Normally, the filter should be set when the load is committed. For
// the sake of this test, however, inject it earlier to verify that it
// is not consulted for the main resource load.
m_subresourceFilter =
new TestDocumentSubresourceFilter(m_allowSubresourcesFromNextLoad);
- localFrame->provisionalDataSource()->setSubresourceFilter(
- m_subresourceFilter);
+ dataSource->setSubresourceFilter(m_subresourceFilter);
}
void setAllowSubresourcesFromNextLoad(bool allow) {
« no previous file with comments | « third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698