Send orientation change events to sub frames even if parent isn't active.

third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/screen_orientation/ScreenOrientationControllerImpl.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/TaskRunnerHelper.h"
 #include "core/events/Event.h"
 #include "core/frame/FrameHost.h"
@@ skipping 83 matching lines @@
     // ourselves.
     orientationType = computeOrientation(chromeClient.screenInfo().rect,
                                          screenInfo.orientationAngle);
   }
   DCHECK(orientationType != WebScreenOrientationUndefined);
 
   m_orientation->setType(orientationType);
   m_orientation->setAngle(screenInfo.orientationAngle);
 }
 
+bool ScreenOrientationControllerImpl::isActive() const {
+  return m_orientation && m_client;
+}
+
+bool ScreenOrientationControllerImpl::isVisible() const {
+  return page() && page()->isPageVisible();
+}
+
 bool ScreenOrientationControllerImpl::isActiveAndVisible() const {
-  return m_orientation && m_client && page() && page()->isPageVisible();
+  return isActive() && isVisible();
 }
 
 void ScreenOrientationControllerImpl::pageVisibilityChanged() {
   notifyDispatcher();
 
   if (!isActiveAndVisible())
     return;
 
   DCHECK(frame());
   DCHECK(frame()->host());
 
   // The orientation type and angle are tied in a way that if the angle has
   // changed, the type must have changed.
   unsigned short currentAngle =
       frame()->host()->chromeClient().screenInfo().orientationAngle;
 
   // FIXME: sendOrientationChangeEvent() currently send an event all the
   // children of the frame, so it should only be called on the frame on
   // top of the tree. We would need the embedder to call
   // sendOrientationChangeEvent on every WebFrame part of a WebView to be
   // able to remove this.
   if (frame() == frame()->localFrameRoot() &&
       m_orientation->angle() != currentAngle)
     notifyOrientationChanged();
 }
 
 void ScreenOrientationControllerImpl::notifyOrientationChanged() {
-  if (!isActiveAndVisible())
+  if (!isVisible())
     return;
 
-  updateOrientation();
+  if (isActive())
+    updateOrientation();
 
   // Keep track of the frames that need to be notified before notifying the
   // current frame as it will prevent side effects from the change event
   // handlers.
   HeapVector<Member<LocalFrame>> childFrames;
   for (Frame* child = frame()->tree().firstChild(); child;
        child = child->tree().nextSibling()) {
     if (child->isLocalFrame())
       childFrames.push_back(toLocalFrame(child));
   }
 
   // Notify current orientation object.
-  if (!m_dispatchEventTimer.isActive())
+  if (isActive() && !m_dispatchEventTimer.isActive())
     m_dispatchEventTimer.startOneShot(0, BLINK_FROM_HERE);
 
   // ... and child frames, if they have a ScreenOrientationControllerImpl.
   for (size_t i = 0; i < childFrames.size(); ++i) {
     if (ScreenOrientationControllerImpl* controller =
-            ScreenOrientationControllerImpl::from(*childFrames[i]))
+            ScreenOrientationControllerImpl::from(*childFrames[i])) {
       controller->notifyOrientationChanged();
+    }
   }
 }
 
 void ScreenOrientationControllerImpl::setOrientation(
     ScreenOrientation* orientation) {
   m_orientation = orientation;
   if (m_orientation)
     updateOrientation();
   notifyDispatcher();
 }
@@ skipping 58 matching lines @@
 }
 
 DEFINE_TRACE(ScreenOrientationControllerImpl) {
   visitor->trace(m_orientation);
   ContextLifecycleObserver::trace(visitor);
   Supplement<LocalFrame>::trace(visitor);
   PlatformEventController::trace(visitor);
 }
 
 }  // namespace blink