Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2661623003: Revert of DevTools: Move radio button input element into Shadow DOM (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Move radio button input element into Shadow DOM (patchset #1 id:1 of https://codereview.chromium.org/2650213005/ ) Reason for revert: Breaks all the radio buttons Original issue's description: > DevTools: Move radio button input element into Shadow DOM > > BUG=685385 > > Review-Url: https://codereview.chromium.org/2650213005 > Cr-Commit-Position: refs/heads/master@{#446606} > Committed: https://chromium.googlesource.com/chromium/src/+/b115a08ad32ae5beda325c98ba50446b7e034eab TBR=dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=685385 Review-Url: https://codereview.chromium.org/2661623003 Cr-Commit-Position: refs/heads/master@{#446843} Committed: https://chromium.googlesource.com/chromium/src/+/50ae54449909cd460dfa06eb4bcef261363e8cb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css View 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/radioButton.css View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
einbinder
Created Revert of DevTools: Move radio button input element into Shadow DOM
3 years, 10 months ago (2017-01-28 00:14:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661623003/1
3 years, 10 months ago (2017-01-28 00:15:06 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-01-28 00:15:07 UTC) #5
dgozman
lgtm
3 years, 10 months ago (2017-01-28 00:16:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661623003/1
3 years, 10 months ago (2017-01-28 00:17:34 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 00:18:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50ae54449909cd460dfa06eb4bce...

Powered by Google App Engine
This is Rietveld 408576698