Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2650213005: DevTools: Move radio button input element into Shadow DOM (Closed)

Created:
3 years, 11 months ago by einbinder
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Move radio button input element into Shadow DOM BUG=685385 Review-Url: https://codereview.chromium.org/2650213005 Cr-Commit-Position: refs/heads/master@{#446606} Committed: https://chromium.googlesource.com/chromium/src/+/b115a08ad32ae5beda325c98ba50446b7e034eab

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css View 2 chunks +1 line, -9 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/radioButton.css View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
einbinder
ptal https://codereview.chromium.org/2650213005/diff/1/third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css File third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css (left): https://codereview.chromium.org/2650213005/diff/1/third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css#oldcode60 third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css:60: .network-config-ua label[is="dt-radio"].checked > * { This css wasn't ...
3 years, 11 months ago (2017-01-25 22:55:28 UTC) #2
dgozman
lgtm
3 years, 10 months ago (2017-01-26 23:23:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650213005/1
3 years, 10 months ago (2017-01-27 00:09:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/299172)
3 years, 10 months ago (2017-01-27 01:05:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650213005/1
3 years, 10 months ago (2017-01-27 01:48:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/379326)
3 years, 10 months ago (2017-01-27 04:32:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650213005/1
3 years, 10 months ago (2017-01-27 04:37:55 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b115a08ad32ae5beda325c98ba50446b7e034eab
3 years, 10 months ago (2017-01-27 05:59:57 UTC) #16
einbinder
3 years, 10 months ago (2017-01-28 00:14:34 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2661623003/ by einbinder@chromium.org.

The reason for reverting is: Breaks all the radio buttons.

Powered by Google App Engine
This is Rietveld 408576698