Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Issue 2661573002: DevTools: skip specific tests for backwards compatibility testing (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: skip specific tests for backwards compatibility testing Created a new TestExpectations file for the backwards compatibility tests with specific reasons why certain types of tests are skipped. BUG=682078 Review-Url: https://codereview.chromium.org/2661573002 Cr-Commit-Position: refs/heads/master@{#446826} Committed: https://chromium.googlesource.com/chromium/src/+/45d7c03cf6c50bf18b9d518b42b76b3b47308682

Patch Set 1 #

Total comments: 2

Patch Set 2 : devtools runtime #

Total comments: 2

Patch Set 3 : cl comment #

Patch Set 4 : add skip expectations for inspector-unit #

Messages

Total messages: 16 (8 generated)
chenwilliam
ptal. there's a few tests (~4) that still aren't running properly (crash / timeout) but ...
3 years, 10 months ago (2017-01-27 02:34:53 UTC) #2
pfeldman
https://codereview.chromium.org/2661573002/diff/1/third_party/WebKit/Source/devtools/tests/TestExpectations File third_party/WebKit/Source/devtools/tests/TestExpectations (right): https://codereview.chromium.org/2661573002/diff/1/third_party/WebKit/Source/devtools/tests/TestExpectations#newcode38 third_party/WebKit/Source/devtools/tests/TestExpectations:38: # Skipping async await tests b/c 1.2 content shell ...
3 years, 10 months ago (2017-01-27 18:38:01 UTC) #3
chenwilliam
https://codereview.chromium.org/2661573002/diff/1/third_party/WebKit/Source/devtools/tests/TestExpectations File third_party/WebKit/Source/devtools/tests/TestExpectations (right): https://codereview.chromium.org/2661573002/diff/1/third_party/WebKit/Source/devtools/tests/TestExpectations#newcode38 third_party/WebKit/Source/devtools/tests/TestExpectations:38: # Skipping async await tests b/c 1.2 content shell ...
3 years, 10 months ago (2017-01-27 20:00:26 UTC) #4
dgozman
lgtm https://codereview.chromium.org/2661573002/diff/20001/third_party/WebKit/Source/devtools/tests/TestExpectations File third_party/WebKit/Source/devtools/tests/TestExpectations (right): https://codereview.chromium.org/2661573002/diff/20001/third_party/WebKit/Source/devtools/tests/TestExpectations#newcode1 third_party/WebKit/Source/devtools/tests/TestExpectations:1: # Skipping service worker tests because it's an ...
3 years, 10 months ago (2017-01-27 20:06:47 UTC) #5
chenwilliam
https://codereview.chromium.org/2661573002/diff/20001/third_party/WebKit/Source/devtools/tests/TestExpectations File third_party/WebKit/Source/devtools/tests/TestExpectations (right): https://codereview.chromium.org/2661573002/diff/20001/third_party/WebKit/Source/devtools/tests/TestExpectations#newcode1 third_party/WebKit/Source/devtools/tests/TestExpectations:1: # Skipping service worker tests because it's an experimental ...
3 years, 10 months ago (2017-01-27 21:53:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661573002/40001
3 years, 10 months ago (2017-01-27 21:54:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661573002/60001
3 years, 10 months ago (2017-01-27 22:01:18 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 23:34:45 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/45d7c03cf6c50bf18b9d518b42b7...

Powered by Google App Engine
This is Rietveld 408576698