DevTools: rebaselined network tests for backwards compatibility

DevTools: rebaselined network tests for backwards compatibility

http/tests/inspector/resource-tree/cached-resource-metadata.html did not exist yet
http/tests/inspector-protocol/request-referrer-policy.html did not exist yet
LayoutTests/http/tests/inspector-protocol/reload-memory-cache.html wasn't fixed yet

BUG=682078
Review-Url: https://codereview.chromium.org/2654433015
Cr-Commit-Position: refs/heads/master@{#447107}
Committed: https://chromium.googlesource.com/chromium/src/+/3809eb577f75f4ad4ff2998a10f4e9448b14c298

[chenwilliam, 2017-01-27 23:36:20]

Description was changed from

==========
DevTools: rebaselined network tests for backwards compatibility

http/tests/inspector/resource-tree/cached-resource-metadata.html did not exist
yet
http/tests/inspector-protocol/request-referrer-policy.html did not exist yet
LayoutTests/http/tests/inspector-protocol/reload-memory-cache wasn't fixed yet

BUG=682078
==========

to

==========
DevTools: rebaselined network tests for backwards compatibility

http/tests/inspector/resource-tree/cached-resource-metadata.html did not exist
yet
http/tests/inspector-protocol/request-referrer-policy.html did not exist yet
LayoutTests/http/tests/inspector-protocol/reload-memory-cache.html wasn't fixed
yet

BUG=682078
==========

[chenwilliam, 2017-01-27 23:36:20]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2017-01-27 23:37:04]

ptal - I couldn't figure out how to get a nicer diff :( (git doesn't recognize
some of these as copies)

[dgozman, 2017-01-28 03:12:36]

dgozman@chromium.org changed reviewers:
+ allada@chromium.org

[dgozman, 2017-01-28 03:12:36]

Adding Blaise.

https://codereview.chromium.org/2654433015/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived-expected.txt
(right):

https://codereview.chromium.org/2654433015/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived-expected.txt:5:
Expected data length: 50383
Blaise, can this value change? I'm worried this could be flaky.

[chenwilliam, 2017-01-30 20:09:20]

ptal.

https://codereview.chromium.org/2654433015/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived-expected.txt
(right):

https://codereview.chromium.org/2654433015/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived-expected.txt:5:
Expected data length: 50383
On 2017/01/28 03:12:36, dgozman wrote:
> Blaise, can this value change? I'm worried this could be flaky.

I talked with @allada and he said this test is possibly flaky. I added a disable
network cache to the test but it's still getting an off-by-one value w/ the old
content shell. For now, we've agreed to skip the test and re-visit it later,
particularly if Node.js decides to implement Network functionality.

[dgozman, 2017-01-30 20:53:36]

lgtm modulo 2 tests

https://codereview.chromium.org/2654433015/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived-expected.txt
(right):

https://codereview.chromium.org/2654433015/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived-expected.txt:5:
Expected data length: 50383
Let's not touch the test at all.

https://codereview.chromium.org/2654433015/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/http/tests/inspector-protocol/reload-memory-cache-expected.txt
(right):

https://codereview.chromium.org/2654433015/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/http/tests/inspector-protocol/reload-memory-cache-expected.txt:3:
This should never be reached.
I don't remember us changing the ignoreCache recently. Blaise?

[chenwilliam, 2017-01-30 21:51:24]

https://codereview.chromium.org/2654433015/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived-expected.txt
(right):

https://codereview.chromium.org/2654433015/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived-expected.txt:5:
Expected data length: 50383
On 2017/01/30 20:53:35, dgozman wrote:
> Let's not touch the test at all.

Done.

https://codereview.chromium.org/2654433015/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/http/tests/inspector-protocol/reload-memory-cache-expected.txt
(right):

https://codereview.chromium.org/2654433015/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/http/tests/inspector-protocol/reload-memory-cache-expected.txt:3:
This should never be reached.
On 2017/01/30 20:53:35, dgozman wrote:
> I don't remember us changing the ignoreCache recently. Blaise?

This bug was fixed / test added in
https://chromium.googlesource.com/chromium/src/+/ce98e6c4a756a41f57ff444a4026...
which was right after the protocol move (crrev.com/417361)

[chenwilliam, 2017-01-30 21:51:29]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-01-30 21:51:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2654433015/#ps100001
(title: "undo network-datareceived")

[commit-bot: I haz the power, 2017-01-30 21:52:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 23:14:47]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485813089917430,
"parent_rev": "6c39abeb2530a224517e3e3a5291e95e0faf581c", "commit_rev":
"3809eb577f75f4ad4ff2998a10f4e9448b14c298"}

[commit-bot: I haz the power, 2017-01-30 23:15:29]

Description was changed from

==========
DevTools: rebaselined network tests for backwards compatibility

http/tests/inspector/resource-tree/cached-resource-metadata.html did not exist
yet
http/tests/inspector-protocol/request-referrer-policy.html did not exist yet
LayoutTests/http/tests/inspector-protocol/reload-memory-cache.html wasn't fixed
yet

BUG=682078
==========

to

==========
DevTools: rebaselined network tests for backwards compatibility

http/tests/inspector/resource-tree/cached-resource-metadata.html did not exist
yet
http/tests/inspector-protocol/request-referrer-policy.html did not exist yet
LayoutTests/http/tests/inspector-protocol/reload-memory-cache.html wasn't fixed
yet

BUG=682078

Review-Url: https://codereview.chromium.org/2654433015
Cr-Commit-Position: refs/heads/master@{#447107}
Committed:
https://chromium.googlesource.com/chromium/src/+/3809eb577f75f4ad4ff2998a10f4...
==========

[commit-bot: I haz the power, 2017-01-30 23:15:30]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/3809eb577f75f4ad4ff2998a10f4...