Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2661553002: Revert of Merged: [wasm] Fix check failure on invalid name section (Closed)

Created:
3 years, 10 months ago by bradnelson
Modified:
3 years, 10 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Revert of Merged: [wasm] Fix check failure on invalid name section (patchset #1 id:1 of https://codereview.chromium.org/2657113002/ ) Reason for revert: Has an order dependency. Original issue's description: > Merged: [wasm] Fix check failure on invalid name section > > Revision: 0ec3a264bcba5c899f7e72fa5b98dd191477e272 > > BUG=chromium:684858 > LOG=N > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > R=mtrofin@chromium.org > > Review-Url: https://codereview.chromium.org/2657113002 . > Cr-Commit-Position: refs/branch-heads/5.7@{#33} > Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} > Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} > Committed: https://chromium.googlesource.com/v8/v8/+/98cc297fceaa828b8d4a86a8b1f2809ae7445480 TBR=mtrofin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:684858 Review-Url: https://codereview.chromium.org/2661553002 Cr-Commit-Position: refs/branch-heads/5.7@{#42} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/3795989355818b4503b53761f33aded18c368208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/wasm/module-decoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
bradnelson
Created Revert of Merged: [wasm] Fix check failure on invalid name section
3 years, 10 months ago (2017-01-27 02:03:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661553002/1
3 years, 10 months ago (2017-01-27 02:03:18 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 02:03:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3795989355818b4503b53761f33aded18c3...

Powered by Google App Engine
This is Rietveld 408576698