Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2657113002: Merged: [wasm] Fix check failure on invalid name section (Closed)

Created:
3 years, 10 months ago by bradnelson
Modified:
3 years, 10 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: [wasm] Fix check failure on invalid name section Revision: 0ec3a264bcba5c899f7e72fa5b98dd191477e272 BUG=chromium:684858 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2657113002 . Cr-Commit-Position: refs/branch-heads/5.7@{#33} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/98cc297fceaa828b8d4a86a8b1f2809ae7445480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/wasm/module-decoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
bradnelson
3 years, 10 months ago (2017-01-27 01:03:49 UTC) #1
bradnelson
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-01-27 01:03:50 UTC) #2
Mircea Trofin
lgtm
3 years, 10 months ago (2017-01-27 01:04:59 UTC) #3
bradnelson
Committed patchset #1 (id:1) manually as 98cc297fceaa828b8d4a86a8b1f2809ae7445480.
3 years, 10 months ago (2017-01-27 01:05:23 UTC) #5
bradnelson
3 years, 10 months ago (2017-01-27 02:03:10 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2661553002/ by bradnelson@chromium.org.

The reason for reverting is: Has an order dependency..

Powered by Google App Engine
This is Rietveld 408576698